Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1494)

Unified Diff: chrome/browser/ui/task_manager/task_manager_columns.cc

Issue 2573183002: Add process start time and CPU time columns to task manager (Closed)
Patch Set: Fix nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/task_manager/task_manager_columns.cc
diff --git a/chrome/browser/ui/task_manager/task_manager_columns.cc b/chrome/browser/ui/task_manager/task_manager_columns.cc
index 69f9e696ace9fd92443cacb23039c1ff6d76052c..4a08e5e3e5b2ee932eb29f06701d0d3f09712e7b 100644
--- a/chrome/browser/ui/task_manager/task_manager_columns.cc
+++ b/chrome/browser/ui/task_manager/task_manager_columns.cc
@@ -39,6 +39,12 @@ const TableColumnData kColumns[] = {
{ IDS_TASK_MANAGER_CPU_COLUMN, ui::TableColumn::RIGHT, -1, 0,
arraysize("99.9") * kCharWidth, -1, true, false, true },
+#if defined(OS_WIN)
+ { IDS_TASK_MANAGER_CPU_TIME_COLUMN, ui::TableColumn::RIGHT, -1, 0,
+ arraysize("15h 42m 30s") * kCharWidth, -1, true, false, true },
stanisc 2016/12/19 22:44:10 This might be more than 100 hours. I suggest 999h
chengx 2016/12/20 00:51:13 Good point. I will 1234h just in case. Actually, w
+ { IDS_TASK_MANAGER_START_TIME_COLUMN, ui::TableColumn::RIGHT, -1, 0,
+ arraysize("12/13/14 11:44:30 PM") * kCharWidth, -1, true, false, true },
+#endif
{ IDS_TASK_MANAGER_NET_COLUMN, ui::TableColumn::RIGHT, -1, 0,
arraysize("150 kiB/s") * kCharWidth, -1, true, false, true },
{ IDS_TASK_MANAGER_PROCESS_ID_COLUMN, ui::TableColumn::RIGHT, -1, 0,
@@ -101,6 +107,8 @@ const char kSortIsAscendingKey[] = "sort_is_ascending";
def(IDS_TASK_MANAGER_PRIVATE_MEM_COLUMN) \
def(IDS_TASK_MANAGER_SWAPPED_MEM_COLUMN) \
def(IDS_TASK_MANAGER_CPU_COLUMN) \
+ def(IDS_TASK_MANAGER_START_TIME_COLUMN) \
+ def(IDS_TASK_MANAGER_CPU_TIME_COLUMN) \
def(IDS_TASK_MANAGER_NET_COLUMN) \
def(IDS_TASK_MANAGER_PROCESS_ID_COLUMN) \
def(IDS_TASK_MANAGER_GDI_HANDLES_COLUMN) \

Powered by Google App Engine
This is Rietveld 408576698