Add process start time and CPU time columns to task manager

chrome/browser/ui/task_manager/task_manager_columns.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/task_manager/task_manager_columns.h"
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/grit/generated_resources.h"
@@ skipping 21 matching lines @@
   { IDS_TASK_MANAGER_PRIVATE_MEM_COLUMN, ui::TableColumn::RIGHT, -1, 0,
     arraysize("800 MiB") * kCharWidth, -1, true, false, false },
 
 #if defined(OS_CHROMEOS)
   { IDS_TASK_MANAGER_SWAPPED_MEM_COLUMN, ui::TableColumn::RIGHT, -1, 0,
     arraysize("800 MiB") * kCharWidth, -1, true, false, false },
 #endif
 
   { IDS_TASK_MANAGER_CPU_COLUMN, ui::TableColumn::RIGHT, -1, 0,
     arraysize("99.9") * kCharWidth, -1, true, false, true },
+#if defined(OS_WIN)
+  { IDS_TASK_MANAGER_CPU_TIME_COLUMN, ui::TableColumn::RIGHT, -1, 0,
+    arraysize("15h 42m 30s") * kCharWidth, -1, true, false, true },

[stanisc, 2016/12/19 22:44:10]

This might be more than 100 hours. I suggest 999h instead.
Also, is this the CPU time format we are using? I thought it was compact format.

[chengx, 2016/12/20 00:51:13]

Good point. I will 1234h just in case. Actually, we have a bug with the compact
format when hour is larger than 24, which is be converted to the value mod by
24. I will fix it in another CL. So for now, I will stay with "15h 42m 30s"
format.

+  { IDS_TASK_MANAGER_START_TIME_COLUMN, ui::TableColumn::RIGHT, -1, 0,
+    arraysize("12/13/14 11:44:30 PM") * kCharWidth, -1, true, false, true },
+#endif
   { IDS_TASK_MANAGER_NET_COLUMN, ui::TableColumn::RIGHT, -1, 0,
     arraysize("150 kiB/s") * kCharWidth, -1, true, false, true },
   { IDS_TASK_MANAGER_PROCESS_ID_COLUMN, ui::TableColumn::RIGHT, -1, 0,
     arraysize("73099  ") * kCharWidth, -1, true, true, true },
 
 #if defined(OS_WIN)
   { IDS_TASK_MANAGER_GDI_HANDLES_COLUMN, ui::TableColumn::RIGHT, -1, 0, 0, 0,
     true, false, false },
   { IDS_TASK_MANAGER_USER_HANDLES_COLUMN, ui::TableColumn::RIGHT, -1, 0, 0, 0,
     true, false, false },
@@ skipping 42 matching lines @@
 // string "IDS_TASK_MANAGER_TASK_COLUMN". The following macros help us
 // efficiently get the literal ID for the integer value.
 #define COLUMNS_LIST(def) \
   def(IDS_TASK_MANAGER_TASK_COLUMN) \
   def(IDS_TASK_MANAGER_PROFILE_NAME_COLUMN) \
   def(IDS_TASK_MANAGER_PHYSICAL_MEM_COLUMN) \
   def(IDS_TASK_MANAGER_SHARED_MEM_COLUMN) \
   def(IDS_TASK_MANAGER_PRIVATE_MEM_COLUMN) \
   def(IDS_TASK_MANAGER_SWAPPED_MEM_COLUMN) \
   def(IDS_TASK_MANAGER_CPU_COLUMN) \
+  def(IDS_TASK_MANAGER_START_TIME_COLUMN) \
+  def(IDS_TASK_MANAGER_CPU_TIME_COLUMN) \
   def(IDS_TASK_MANAGER_NET_COLUMN) \
   def(IDS_TASK_MANAGER_PROCESS_ID_COLUMN) \
   def(IDS_TASK_MANAGER_GDI_HANDLES_COLUMN) \
   def(IDS_TASK_MANAGER_USER_HANDLES_COLUMN) \
   def(IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN) \
   def(IDS_TASK_MANAGER_WEBCORE_SCRIPTS_CACHE_COLUMN) \
   def(IDS_TASK_MANAGER_WEBCORE_CSS_CACHE_COLUMN) \
   def(IDS_TASK_MANAGER_VIDEO_MEMORY_COLUMN) \
   def(IDS_TASK_MANAGER_SQLITE_MEMORY_USED_COLUMN) \
   def(IDS_TASK_MANAGER_NACL_DEBUG_STUB_PORT_COLUMN) \
   def(IDS_TASK_MANAGER_JAVASCRIPT_MEMORY_ALLOCATED_COLUMN) \
   def(IDS_TASK_MANAGER_IDLE_WAKEUPS_COLUMN) \
   def(IDS_TASK_MANAGER_OPEN_FD_COUNT_COLUMN) \
   def(IDS_TASK_MANAGER_PROCESS_PRIORITY_COLUMN)
 // Add to the above list in the macro any new IDs added in the future. Also
 // remove the removed ones.
 
 #define COLUMN_ID_AS_STRING(col_id) case col_id: return std::string(#col_id);
 
 std::string GetColumnIdAsString(int column_id) {
   switch (column_id) {
     COLUMNS_LIST(COLUMN_ID_AS_STRING)
     default:
       NOTREACHED();
       return std::string();
   }
 }
 
 }  // namespace task_manager