Do not check for ASCII in WebSecurityOrigin->Origin conversion

Do not check for ASCII in WebSecurityOrigin->Origin conversion

Protocols, hosts, and suborigins are guaranteed to be canonicalized to
ASCII. Using WebString::ascii DCHECKs this fact, whereas WebString::utf8
branches on it. Using ascii() prevents a scan-through of each part of
the origin.

BUG=672877
Committed: https://crrev.com/8327037293547a118f463e2e359274b51de1d6d3
Cr-Commit-Position: refs/heads/master@{#438858}

[Charlie Harrison, 2016-12-14 15:02:30]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 15:02:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-12-14 15:12:13]

csharrison@chromium.org changed reviewers:
+ mkwst@chromium.org

[Charlie Harrison, 2016-12-14 15:12:14]

mkwst: PTAL? (trivial)

I traced the suborigin code and it seems ok to DCHECK that it will contain only
ascii chars at this point.

[Charlie Harrison, 2016-12-14 15:16:26]

cc kinuko because on platform-architecture-dev@ we chatted about unnecessary
containsOnlyASCII() checks. Anytime we are operating on protocols/hosts we
should *not* need this kind of scanning.

[commit-bot: I haz the power, 2016-12-14 15:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 15:49:01]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mike West, 2016-12-15 14:54:59]

LGTM.

[Charlie Harrison, 2016-12-15 15:57:44]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-12-15 15:58:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2016-12-15 15:58:37]

lgtm/2!

[commit-bot: I haz the power, 2016-12-15 17:22:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481817464844710, "parent_rev":
"abade360cae02e93e2e267abb60d4971250584f4", "commit_rev":
"86d32037b337d7625e84750069ebfd127d82c61d"}

[commit-bot: I haz the power, 2016-12-15 17:22:51]

Description was changed from

==========
Do not check for ASCII in WebSecurityOrigin->Origin conversion

Protocols, hosts, and suborigins are guaranteed to be canonicalized to
ASCII. Using WebString::ascii DCHECKs this fact, whereas WebString::utf8
branches on it. Using ascii() prevents a scan-through of each part of
the origin.

BUG=672877
==========

to

==========
Do not check for ASCII in WebSecurityOrigin->Origin conversion

Protocols, hosts, and suborigins are guaranteed to be canonicalized to
ASCII. Using WebString::ascii DCHECKs this fact, whereas WebString::utf8
branches on it. Using ascii() prevents a scan-through of each part of
the origin.

BUG=672877

Review-Url: https://codereview.chromium.org/2573113002
==========

[commit-bot: I haz the power, 2016-12-15 17:22:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-15 17:25:12]

Description was changed from

==========
Do not check for ASCII in WebSecurityOrigin->Origin conversion

Protocols, hosts, and suborigins are guaranteed to be canonicalized to
ASCII. Using WebString::ascii DCHECKs this fact, whereas WebString::utf8
branches on it. Using ascii() prevents a scan-through of each part of
the origin.

BUG=672877

Review-Url: https://codereview.chromium.org/2573113002
==========

to

==========
Do not check for ASCII in WebSecurityOrigin->Origin conversion

Protocols, hosts, and suborigins are guaranteed to be canonicalized to
ASCII. Using WebString::ascii DCHECKs this fact, whereas WebString::utf8
branches on it. Using ascii() prevents a scan-through of each part of
the origin.

BUG=672877

Committed: https://crrev.com/8327037293547a118f463e2e359274b51de1d6d3
Cr-Commit-Position: refs/heads/master@{#438858}
==========

[commit-bot: I haz the power, 2016-12-15 17:25:16]

Patchset 1 (id:??) landed as
https://crrev.com/8327037293547a118f463e2e359274b51de1d6d3
Cr-Commit-Position: refs/heads/master@{#438858}