Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2375)

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)
Patch Set: Fix nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/pepper_plugin_instance_impl.cc
diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc
index 29ae971ccf42228faee2312c395681070a7b8147..2c0414808ee55b4a9f6d7e0741fd3c7844844557 100644
--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc
+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc
@@ -320,8 +320,8 @@ std::unique_ptr<const char* []> StringVectorToArgArray(
// for things like screen brightness and volume control.
bool IsReservedSystemInputEvent(const blink::WebInputEvent& event) {
#if defined(OS_CHROMEOS)
- if (event.type != WebInputEvent::KeyDown &&
- event.type != WebInputEvent::KeyUp)
+ if (event.type() != WebInputEvent::KeyDown &&
+ event.type() != WebInputEvent::KeyUp)
return false;
const blink::WebKeyboardEvent& key_event =
static_cast<const blink::WebKeyboardEvent&>(event);
@@ -1121,8 +1121,8 @@ bool PepperPluginInstanceImpl::HandleInputEvent(
TRACE_EVENT0("ppapi", "PepperPluginInstanceImpl::HandleInputEvent");
if (!has_been_clicked_ && is_flash_plugin_ &&
- event.type == blink::WebInputEvent::MouseDown &&
- (event.modifiers & blink::WebInputEvent::LeftButtonDown)) {
+ event.type() == blink::WebInputEvent::MouseDown &&
+ (event.modifiers() & blink::WebInputEvent::LeftButtonDown)) {
has_been_clicked_ = true;
blink::WebRect bounds = container()->element().boundsInViewport();
render_frame()->GetRenderWidget()->convertViewportToWindow(&bounds);
@@ -1134,7 +1134,7 @@ bool PepperPluginInstanceImpl::HandleInputEvent(
if (!render_frame_)
return false;
- if (WebInputEvent::isMouseEventType(event.type)) {
+ if (WebInputEvent::isMouseEventType(event.type())) {
render_frame_->PepperDidReceiveMouseEvent(this);
}
« no previous file with comments | « content/renderer/pepper/event_conversion_unittest.cc ('k') | content/renderer/pepper/plugin_instance_throttler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698