Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1971)

Unified Diff: content/renderer/pepper/plugin_instance_throttler_impl.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)
Patch Set: Fix nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/pepper_plugin_instance_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/plugin_instance_throttler_impl.cc
diff --git a/content/renderer/pepper/plugin_instance_throttler_impl.cc b/content/renderer/pepper/plugin_instance_throttler_impl.cc
index 7bf7d967ffbc75f06e51ed3be8ec736df1b8cbbd..19e731cbd7382f4dcef2f27394ca2b9f71a9c29d 100644
--- a/content/renderer/pepper/plugin_instance_throttler_impl.cc
+++ b/content/renderer/pepper/plugin_instance_throttler_impl.cc
@@ -200,12 +200,12 @@ bool PluginInstanceThrottlerImpl::ConsumeInputEvent(
// TODO(tommycli): We should instead show a custom context menu (probably
// using PluginPlaceholder) so users aren't confused and try to click the
// Flash-internal 'Play' menu item. This is a stopgap solution.
- if (event.modifiers & blink::WebInputEvent::Modifiers::RightButtonDown)
+ if (event.modifiers() & blink::WebInputEvent::Modifiers::RightButtonDown)
return false;
if (state_ != THROTTLER_STATE_MARKED_ESSENTIAL &&
- event.type == blink::WebInputEvent::MouseUp &&
- (event.modifiers & blink::WebInputEvent::LeftButtonDown)) {
+ event.type() == blink::WebInputEvent::MouseUp &&
+ (event.modifiers() & blink::WebInputEvent::LeftButtonDown)) {
bool was_throttled = IsThrottled();
MarkPluginEssential(UNTHROTTLE_METHOD_BY_CLICK);
return was_throttled;
« no previous file with comments | « content/renderer/pepper/pepper_plugin_instance_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698