chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/page_load_metrics/user_input_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

index 083bc4c300947b61b206ee868a44788958197740..9b6e76c8795ea052f7bc6cccb3693dd71098ef95 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

@@ -577,7 +577,7 @@ void CorePageLoadMetricsObserver::OnUserInput(

base::TimeTicks now;

if (!first_paint_.is_null() &&

first_user_interaction_after_first_paint_.is_null() &&

- event.type != blink::WebInputEvent::MouseMove) {

+ event.type() != blink::WebInputEvent::MouseMove) {

if (now.is_null())

now = base::TimeTicks::Now();

first_user_interaction_after_first_paint_ = now;

@@ -587,8 +587,8 @@ void CorePageLoadMetricsObserver::OnUserInput(

return;

if (!received_non_scroll_input_after_first_paint_) {

- if (event.type == blink::WebInputEvent::GestureTap ||

- event.type == blink::WebInputEvent::MouseUp) {

+ if (event.type() == blink::WebInputEvent::GestureTap ||

+ event.type() == blink::WebInputEvent::MouseUp) {

received_non_scroll_input_after_first_paint_ = true;

if (now.is_null())

now = base::TimeTicks::Now();

@@ -598,7 +598,7 @@ void CorePageLoadMetricsObserver::OnUserInput(

}

if (!received_scroll_input_after_first_paint_ &&

- event.type == blink::WebInputEvent::GestureScrollBegin) {

+ event.type() == blink::WebInputEvent::GestureScrollBegin) {

received_scroll_input_after_first_paint_ = true;

if (now.is_null())

now = base::TimeTicks::Now();