chrome/browser/page_load_metrics/metrics_web_contents_observer.cc - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

index 926978a722908430d4ab523137ffa0f6886562dd..f11b41a79e51397025915a900dc805549bcc1e13 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

@@ -309,7 +309,7 @@ void MetricsWebContentsObserver::NavigationStopped() {

void MetricsWebContentsObserver::OnInputEvent(

const blink::WebInputEvent& event) {

// Ignore browser navigation or reload which comes with type Undefined.

- if (event.type == blink::WebInputEvent::Type::Undefined)

+ if (event.type() == blink::WebInputEvent::Type::Undefined)

return;

if (committed_load_)