Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 257303002: Enable x64 build of host toolset in icu52 (Closed)

Created:
6 years, 7 months ago by jungshik at Google
Modified:
6 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews
Visibility:
Public.

Description

Enable x64 build of host toolset in icu52 Port the icu46 gyp file change to icu52. See https://codereview.chromium.org/212593002 BUG=346626, 132145 R=torne@chromium.org TBR=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M icu52/icu.gyp View 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
tbring because it's just applying the patch for icu46 to the icu52 gyp file.
6 years, 7 months ago (2014-04-29 21:27:49 UTC) #1
Torne
lgtm
6 years, 7 months ago (2014-04-30 08:09:30 UTC) #2
jungshik at Google
6 years, 7 months ago (2014-04-30 08:59:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r267148 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698