Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 212593002: Enable x64 build of host toolset (Closed)

Created:
6 years, 9 months ago by Yang Gu
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu46@master
Visibility:
Public.

Description

Enable 64-bit build of host toolset When building v8 mksnapshot host toolset as 64-bit, it requires icu to be 64-bit also. BUG=346626 R=jochen@chromium.org, jshin@chromium.org Committed: 262949

Patch Set 1 #

Patch Set 2 : Add arm64 and mipsel64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M icu.gyp View 1 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Yang Gu
Not sure if changes to icu for Chromium can be reviewed here. If yes, please ...
6 years, 9 months ago (2014-03-26 10:05:53 UTC) #1
Anton
Adding +jochen who is hopefully more familiar with ICU.
6 years, 9 months ago (2014-03-26 18:58:43 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-27 14:31:02 UTC) #3
jungshik at Google
LGTM
6 years, 9 months ago (2014-03-27 17:21:41 UTC) #4
Yang Gu
The CQ bit was checked by yang.gu@intel.com
6 years, 9 months ago (2014-03-28 00:23:43 UTC) #5
Sergey Berezin
On 2014/03/28 00:23:43, Yang Gu wrote: > The CQ bit was checked by mailto:yang.gu@intel.com The ...
6 years, 9 months ago (2014-03-28 16:41:49 UTC) #6
Sergey Berezin
The CQ bit was unchecked by sergeyberezin@chromium.org
6 years, 9 months ago (2014-03-28 16:41:54 UTC) #7
jungshik at Google
On 2014/03/28 16:41:54, Sergey Berezin wrote: > The CQ bit was unchecked by https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=sergeyberezin@chromium.org @yang.gu ...
6 years, 9 months ago (2014-03-28 17:52:24 UTC) #8
Yang Gu
On 2014/03/28 17:52:24, Jungshik Shin wrote: > On 2014/03/28 16:41:54, Sergey Berezin wrote: > > ...
6 years, 8 months ago (2014-03-31 01:29:32 UTC) #9
Torne
Can you also do the same for target_arch=arm64? The same change will be required there ...
6 years, 8 months ago (2014-04-01 15:13:40 UTC) #10
Yang Gu
Added both arm64 and mipsel64, PTAL. Note that I changed the commit message accordingly.
6 years, 8 months ago (2014-04-02 02:20:48 UTC) #11
jochen (gone - plz use gerrit)
still lgtm
6 years, 8 months ago (2014-04-02 09:28:04 UTC) #12
Torne
Jungshik, can you go ahead and land this/roll ICU when you get a chance? Thanks!
6 years, 8 months ago (2014-04-02 09:36:25 UTC) #13
Torne
6 years, 8 months ago (2014-04-10 08:04:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 manually as r262949 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698