MD Settings: Add "Show Google Now cards in the launcher" row in Search section.

MD Settings: Add "Show Google Now cards in the launcher" row in Search section.

"Show Google Now cards" option should populate when it is enabled in field trial
and the default search provider is google.

BUG=614439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb
Cr-Commit-Position: refs/heads/master@{#438776}

[fukino, 2016-12-14 16:26:33]

Description was changed from

==========
MD Settings: Add "Show Google Now cards in the launcher" row in Search section.

BUG=614439
==========

to

==========
MD Settings: Add "Show Google Now cards in the launcher" row in Search section.

BUG=614439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-14 16:32:20]

Description was changed from

==========
MD Settings: Add "Show Google Now cards in the launcher" row in Search section.

BUG=614439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Add "Show Google Now cards in the launcher" row in Search section.

"Show Google Now cards" option should populate when it is enabled in field trial
and the default search provider is google.

BUG=614439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-14 16:37:35]

fukino@chromium.org changed reviewers:
+ stevenjb@chromium.org

[fukino, 2016-12-14 16:37:36]

Hi Steven, could you take a look?

https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_page/search_page.html:79: <div
class="settings-box two-line continuation">
Though this line's change is not a part of Google Now feature, I'm removing the
row separator to match the mock
https://bugs.chromium.org/p/chromium/issues/detail?id=614439#c5.

[stevenjb, 2016-12-14 18:16:06]

Thanks for taking this on!

LGTM

https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_page/search_page.html:79: <div
class="settings-box two-line continuation">
On 2016/12/14 16:37:36, fukino wrote:
> Though this line's change is not a part of Google Now feature, I'm removing
the
> row separator to match the mock
> https://bugs.chromium.org/p/chromium/issues/detail?id=614439#c5.

Acknowledged.

https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_page/search_page.js (right):

https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_page/search_page.js:40: /** @private
{boolean} */
nit: {boolean} is not needed for Polymer Boolean properties.

[fukino, 2016-12-15 04:20:42]

Thank you!

https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_page/search_page.js (right):

https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_page/search_page.js:40: /** @private
{boolean} */
On 2016/12/14 18:16:06, stevenjb wrote:
> nit: {boolean} is not needed for Polymer Boolean properties.

Done.

[fukino, 2016-12-15 04:20:50]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-12-15 04:20:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2572963004/#ps20001
(title: "Remove unnecessary type annotation.")

[commit-bot: I haz the power, 2016-12-15 04:21:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 04:58:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 04:58:22]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fukino, 2016-12-15 06:34:37]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-12-15 06:34:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2572963004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-15 06:34:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 07:41:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481783677959380,
"parent_rev": "93a37b12df97efd487fb525c30c2026e06e24f4f", "commit_rev":
"a07bf7a28885cc427eb6ea87e956bf5584eb2622"}

[commit-bot: I haz the power, 2016-12-15 07:42:15]

Description was changed from

==========
MD Settings: Add "Show Google Now cards in the launcher" row in Search section.

"Show Google Now cards" option should populate when it is enabled in field trial
and the default search provider is google.

BUG=614439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Add "Show Google Now cards in the launcher" row in Search section.

"Show Google Now cards" option should populate when it is enabled in field trial
and the default search provider is google.

BUG=614439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2572963004
==========

[commit-bot: I haz the power, 2016-12-15 07:42:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 07:44:30]

Description was changed from

==========
MD Settings: Add "Show Google Now cards in the launcher" row in Search section.

"Show Google Now cards" option should populate when it is enabled in field trial
and the default search provider is google.

BUG=614439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2572963004
==========

to

==========
MD Settings: Add "Show Google Now cards in the launcher" row in Search section.

"Show Google Now cards" option should populate when it is enabled in field trial
and the default search provider is google.

BUG=614439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb
Cr-Commit-Position: refs/heads/master@{#438776}
==========

[commit-bot: I haz the power, 2016-12-15 07:44:31]

Patchset 3 (id:??) landed as
https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb
Cr-Commit-Position: refs/heads/master@{#438776}