Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2572963004: MD Settings: Add "Show Google Now cards in the launcher" row in Search section. (Closed)

Created:
4 years ago by fukino
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add "Show Google Now cards in the launcher" row in Search section. "Show Google Now cards" option should populate when it is enabled in field trial and the default search provider is google. BUG=614439 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb Cr-Commit-Position: refs/heads/master@{#438776}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unnecessary type annotation. #

Patch Set 3 : Rebase #

Messages

Total messages: 19 (11 generated)
fukino
Hi Steven, could you take a look? https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/settings/search_page/search_page.html File chrome/browser/resources/settings/search_page/search_page.html (right): https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/settings/search_page/search_page.html#newcode79 chrome/browser/resources/settings/search_page/search_page.html:79: <div class="settings-box ...
4 years ago (2016-12-14 16:37:36 UTC) #4
stevenjb
Thanks for taking this on! LGTM https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/settings/search_page/search_page.html File chrome/browser/resources/settings/search_page/search_page.html (right): https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/settings/search_page/search_page.html#newcode79 chrome/browser/resources/settings/search_page/search_page.html:79: <div class="settings-box two-line ...
4 years ago (2016-12-14 18:16:06 UTC) #5
fukino
Thank you! https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/settings/search_page/search_page.js File chrome/browser/resources/settings/search_page/search_page.js (right): https://codereview.chromium.org/2572963004/diff/1/chrome/browser/resources/settings/search_page/search_page.js#newcode40 chrome/browser/resources/settings/search_page/search_page.js:40: /** @private {boolean} */ On 2016/12/14 18:16:06, ...
4 years ago (2016-12-15 04:20:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572963004/20001
4 years ago (2016-12-15 04:21:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/354960)
4 years ago (2016-12-15 04:58:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572963004/40001
4 years ago (2016-12-15 06:34:49 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-15 07:42:16 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-15 07:44:31 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb
Cr-Commit-Position: refs/heads/master@{#438776}

Powered by Google App Engine
This is Rietveld 408576698