Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2572873002: Add ColorBehavior plumbing for 2D canvas drawImage (Closed)

Created:
4 years ago by Justin Novosad
Modified:
4 years ago
CC:
chromium-reviews, krit, dshwang, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, haraken, dglazkov+blink, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ColorBehavior plumbing for 2D canvas drawImage BUG=634542 Committed: https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b Cr-Commit-Position: refs/heads/master@{#438519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -6 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 3 chunks +102 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorBehavior.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Justin Novosad
PTAL
4 years ago (2016-12-13 21:58:43 UTC) #4
zakerinasab1
On 2016/12/13 21:58:43, Justin Novosad wrote: > PTAL lgtm
4 years ago (2016-12-14 14:59:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572873002/1
4 years ago (2016-12-14 15:14:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 15:18:38 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b Cr-Commit-Position: refs/heads/master@{#438519}
4 years ago (2016-12-14 15:21:16 UTC) #15
ikilpatrick
4 years ago (2016-12-14 17:01:43 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698