[MD Bookmarks] Fix segfault when calling chrome.bookmarks.remove().

[MD Bookmarks] Fix segfault when calling chrome.bookmarks.remove().

This CL fixes an issue where a null pointer would get dereferenced when
calling certain bookmarks API functions because they expect a valid
extension. This fails on the new bookmarks page since it is a WebUI and
has no extension. This has been fixed by adding a null check.

BUG=658980
Committed: https://crrev.com/64da903e4cfacff1d9b0124bebee39ec3c64ff16
Cr-Commit-Position: refs/heads/master@{#438463}

[calamity, 2016-12-14 02:18:55]

Description was changed from

==========
[MD Bookmarks] Fix segfault when calling chrome.bookmarks.remove().

This CL fixes an issue where a null pointer would get dereferenced when
calling certain bookmarks API functions because they expect a valid
extension. This has been fixed by adding a null check.

BUG=658980
==========

to

==========
[MD Bookmarks] Fix segfault when calling chrome.bookmarks.remove().

This CL fixes an issue where a null pointer would get dereferenced when
calling certain bookmarks API functions because they expect a valid
extension. This fails on the new bookmarks page since it is a WebUI and
has no extension. This has been fixed by adding a null check.

BUG=658980
==========

[calamity, 2016-12-14 02:19:11]

calamity@chromium.org changed reviewers:
+ zea@chromium.org

[Nicolas Zea, 2016-12-14 05:01:33]

It seems odd that you're invoking an EXTENSIONS_* notification without a valid
extension id. Should there be a different API?

This LGTM as a workaround for now, but it would be good to maybe file a bug to
move to a different API (and add a TODO here to consume it)

[calamity, 2016-12-14 07:27:49]

On 2016/12/14 05:01:33, Nicolas Zea wrote:
> It seems odd that you're invoking an EXTENSIONS_* notification without a valid
> extension id. Should there be a different API?
> 
> This LGTM as a workaround for now, but it would be good to maybe file a bug to
> move to a different API (and add a TODO here to consume it)

Given that the bookmarks API does everything we need, it would be a waste of
engineering effort to duplicate it for semantic correctness. We're basically
reimplementing the bookmark manager (which is currently a component extension)
as a WebUI for speed and code shareability and use the bookmark API in the
same way the old bookmark manager does.

[calamity, 2016-12-14 07:28:02]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-12-14 07:28:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 08:36:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481700482631700, "parent_rev":
"a1a093bae21c1c3a3e308ef3fb734834f8f884ee", "commit_rev":
"e3a5116028a472cb5c78620878e2eddaad314c59"}

[commit-bot: I haz the power, 2016-12-14 08:36:40]

Description was changed from

==========
[MD Bookmarks] Fix segfault when calling chrome.bookmarks.remove().

This CL fixes an issue where a null pointer would get dereferenced when
calling certain bookmarks API functions because they expect a valid
extension. This fails on the new bookmarks page since it is a WebUI and
has no extension. This has been fixed by adding a null check.

BUG=658980
==========

to

==========
[MD Bookmarks] Fix segfault when calling chrome.bookmarks.remove().

This CL fixes an issue where a null pointer would get dereferenced when
calling certain bookmarks API functions because they expect a valid
extension. This fails on the new bookmarks page since it is a WebUI and
has no extension. This has been fixed by adding a null check.

BUG=658980

Review-Url: https://codereview.chromium.org/2572853004
==========

[commit-bot: I haz the power, 2016-12-14 08:36:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 08:39:08]

Description was changed from

==========
[MD Bookmarks] Fix segfault when calling chrome.bookmarks.remove().

This CL fixes an issue where a null pointer would get dereferenced when
calling certain bookmarks API functions because they expect a valid
extension. This fails on the new bookmarks page since it is a WebUI and
has no extension. This has been fixed by adding a null check.

BUG=658980

Review-Url: https://codereview.chromium.org/2572853004
==========

to

==========
[MD Bookmarks] Fix segfault when calling chrome.bookmarks.remove().

This CL fixes an issue where a null pointer would get dereferenced when
calling certain bookmarks API functions because they expect a valid
extension. This fails on the new bookmarks page since it is a WebUI and
has no extension. This has been fixed by adding a null check.

BUG=658980

Committed: https://crrev.com/64da903e4cfacff1d9b0124bebee39ec3c64ff16
Cr-Commit-Position: refs/heads/master@{#438463}
==========

[commit-bot: I haz the power, 2016-12-14 08:39:09]

Patchset 1 (id:??) landed as
https://crrev.com/64da903e4cfacff1d9b0124bebee39ec3c64ff16
Cr-Commit-Position: refs/heads/master@{#438463}