Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2572853002: Replace remaining /TR/ links in SVG IDL (Closed)

Created:
4 years ago by foolip
Modified:
4 years ago
Reviewers:
pdr., fs, Mark Dittmer
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace remaining /TR/ links in SVG IDL In order to get rid of the second link in SVGSVGElement, sync the order with the specs. (But don't include the "deprecated" comment since deprecation means something different in Blink.) BUG=673852 Committed: https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845 Cr-Commit-Position: refs/heads/master@{#438325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -48 lines) Patch
M third_party/WebKit/Source/core/svg/SVGClipPathElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGComponentTransferFunctionElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEBlendElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFECompositeElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDistantLightElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEFloodElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEFuncAElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEFuncBElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEFuncGElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEFuncRElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEImageElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMergeElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMergeNodeElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMorphologyElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEOffsetElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEPointLightElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpotLightElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETileElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMaskElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.idl View 2 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
foolip
PTAL
4 years ago (2016-12-13 20:36:10 UTC) #4
fs
lgtm
4 years ago (2016-12-13 20:40:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572853002/1
4 years ago (2016-12-13 21:47:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572853002/1
4 years ago (2016-12-13 22:26:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 23:08:34 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-13 23:11:17 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/735266cdacea9f085c7b4b864cfa6658517f3845
Cr-Commit-Position: refs/heads/master@{#438325}

Powered by Google App Engine
This is Rietveld 408576698