Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 2572843002: Return unique_ptr<>s from fxcodec/ (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : std::move it #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -129 lines) Patch
M core/fpdfapi/page/cpdf_streamparser.cpp View 5 chunks +8 lines, -18 lines 1 comment Download
M core/fpdfapi/parser/fpdf_parser_decode.h View 2 chunks +19 lines, -0 lines 0 comments Download
M core/fpdfapi/parser/fpdf_parser_decode.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M core/fpdfapi/render/fpdf_render_loadimage.cpp View 4 chunks +14 lines, -30 lines 1 comment Download
M core/fpdfapi/render/render_int.h View 1 chunk +0 lines, -9 lines 0 comments Download
M core/fxcodec/codec/ccodec_basicmodule.h View 1 chunk +9 lines, -6 lines 0 comments Download
M core/fxcodec/codec/ccodec_faxmodule.h View 1 chunk +12 lines, -10 lines 0 comments Download
M core/fxcodec/codec/ccodec_flatemodule.h View 1 chunk +12 lines, -10 lines 0 comments Download
M core/fxcodec/codec/ccodec_jpegmodule.h View 2 chunks +8 lines, -6 lines 0 comments Download
M core/fxcodec/codec/fx_codec.cpp View 1 2 chunks +11 lines, -13 lines 0 comments Download
M core/fxcodec/codec/fx_codec_fax.cpp View 3 chunks +16 lines, -12 lines 0 comments Download
M core/fxcodec/codec/fx_codec_flate.cpp View 1 3 chunks +6 lines, -3 lines 0 comments Download
M core/fxcodec/codec/fx_codec_jpeg.cpp View 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Tom Sepez
Dan, for review. https://codereview.chromium.org/2572843002/diff/20001/core/fpdfapi/page/cpdf_streamparser.cpp File core/fpdfapi/page/cpdf_streamparser.cpp (left): https://codereview.chromium.org/2572843002/diff/20001/core/fpdfapi/page/cpdf_streamparser.cpp#oldcode30 core/fpdfapi/page/cpdf_streamparser.cpp:30: CCodec_ScanlineDecoder* FPDFAPI_CreateFaxDecoder( Note: moved to .h, ...
4 years ago (2016-12-13 19:21:20 UTC) #8
dsinclair
lgtm
4 years ago (2016-12-13 20:47:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572843002/20001
4 years ago (2016-12-13 20:48:00 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 20:48:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/974b4a6c4bceb50bbe5bf316e9e273b62eae...

Powered by Google App Engine
This is Rietveld 408576698