third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp - Issue 2572813003: Form validation: Do not show validation bubble if the page is invisible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2572813003: Form validation: Do not show validation bubble if the page is invisible. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

index 627158c87cfab129f13d433815eec6c5feeb35dd..9e5926ab83fe369e2ab3a18f3feec8d637b1ce0b 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

@@ -452,7 +452,7 @@ void HTMLFormControlElement::findCustomValidationMessageTextDirection(

void HTMLFormControlElement::updateVisibleValidationMessage() {

Page* page = document().page();

- if (!page)

+ if (!page || !page->isPageVisible())

return;

String message;

if (layoutObject() && willValidate())

« no previous file with comments | « no previous file | no next file » | no next file with comments »