Issue 25728006: Change code order in HTMLMetaElement::process()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25728006: Change code order in HTMLMetaElement::process() (Closed)

Created:
7 years, 2 months ago by kenneth.r.christiansen

Modified:
7 years, 2 months ago

Reviewers:
apavlov, abarth-chromium

CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Change code order in HTMLMetaElement::process() Check the name value earlier to avoid unnecessary comparisons. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158941

Patch Set 1 #

Patch Set 2 : use nameValue instead of name() #

Patch Set 3 : Fixed spelling issue #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -10 lines)			Patch
	M	Source/core/html/HTMLMetaElement.cpp	View	1 2	1 chunk	+16 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/25728006/6001

7 years, 2 months ago (2013-10-04 13:21:14 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=6413

7 years, 2 months ago (2013-10-04 15:33:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/25728006/6001

7 years, 2 months ago (2013-10-04 15:46:44 UTC) #5

Message was sent while issue was closed.

Change committed as 158941

Expand Messages | Collapse Messages