Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2572793003: [Chrome OS] Implement the device wallpaper policy. (Closed)

Created:
4 years ago by xdai1
Modified:
4 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chrome OS] Implement the device wallpaper policy. This CL implements the device policy to allow the domain admins to set a device level policy controlled wallpaper for an enterprise managed device. The device policy wallpaper will display on the login screen all the time without requiring a user to log in. The device policy wallpaper is also set as a user's wallpaper if there is no user policy controlled wallpaper and the user hasn't changed his default wallpaper in a user's session. Detailed description of the expected behavior is described as below: - In the login screen, if the device wallpaper policy present, use the device policy wallpaper, otherwise, check if user-selected wallpaper exists, if so, use the user-selected wallpaper, otherwise use OEM default wallpaper. - Within a user session, if the user wallpaper policy present, user the user policy wallpaper, otherwise, check if user has changed his default wallpaper before, if so, use user-slected wallpaper, otherwise, check if the device wallpaper policy present, if so, use the device policy wallpaper, otherwise, use OEM default wallpaper. This is a follow-up CL of https://codereview.chromium.org/2544693002/. BUG=475998 Committed: https://crrev.com/3e55b65c0a88cee2107208b3bde6eaadf0ccc743 Cr-Commit-Position: refs/heads/master@{#438667}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -33 lines) Patch
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h View 4 chunks +38 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 14 chunks +240 lines, -24 lines 0 comments Download
M components/user_manager/user.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/wallpaper/wallpaper_manager_base.h View 3 chunks +21 lines, -1 line 0 comments Download
M components/wallpaper/wallpaper_manager_base.cc View 3 chunks +25 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
xdai1
alemate@, isherman@, could you help review this CL please? Thanks! alemate@: all isherman@: tools/metrics/histograms/histograms.xml
4 years ago (2016-12-13 23:15:31 UTC) #2
Ilya Sherman
histograms.xml lgtm
4 years ago (2016-12-14 01:34:58 UTC) #3
Alexander Alekseev
lgtm
4 years ago (2016-12-14 03:47:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572793003/20001
4 years ago (2016-12-14 20:48:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/199325)
4 years ago (2016-12-14 22:36:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572793003/20001
4 years ago (2016-12-14 22:44:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 23:20:46 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-14 23:22:46 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e55b65c0a88cee2107208b3bde6eaadf0ccc743
Cr-Commit-Position: refs/heads/master@{#438667}

Powered by Google App Engine
This is Rietveld 408576698