Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2572713003: [turbofan] Add a mutex for recording compilation statistics (Closed)

Created:
4 years ago by Leszek Swirski
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add a mutex for recording compilation statistics There was previously a race between different phases recording their first entry -- and thus, their insert order -- on the main and concurrent-compilation thread. This would later manifest as a segfault when creating the sorted array of phases for --turbo-stats (as two phases would have the same insert order and so there would be a gap in the array). Committed: https://crrev.com/1df36a80de9d9d4a8967b976799fb9a7f5f384b3 Cr-Commit-Position: refs/heads/master@{#41669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/compilation-statistics.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compilation-statistics.cc View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Leszek Swirski
Hi Benedikt, I came across this issue while profiling, could you take a look?
4 years ago (2016-12-13 11:24:43 UTC) #5
Benedikt Meurer
Nice, thanks. LGTM.
4 years ago (2016-12-13 12:10:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572713003/1
4 years ago (2016-12-13 12:12:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 12:14:12 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 12:15:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1df36a80de9d9d4a8967b976799fb9a7f5f384b3
Cr-Commit-Position: refs/heads/master@{#41669}

Powered by Google App Engine
This is Rietveld 408576698