[turbofan] Reserve the StateValueList's size before filling it

[turbofan] Reserve the StateValueList's size before filling it

Avoid needless resizing of the StateValueList's fields vector by
reserving its (already known) size.

Committed: https://crrev.com/f3b7f21cbc774b3da784f9f22c2438421c289a8b
Cr-Commit-Position: refs/heads/master@{#41698}

[Leszek Swirski, 2016-12-14 13:39:27]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 13:39:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 14:06:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 14:06:59]

Dry run: This issue passed the CQ dry run.

[Leszek Swirski, 2016-12-14 14:13:49]

leszeks@chromium.org changed reviewers:
+ jarin@chromium.org

[Leszek Swirski, 2016-12-14 14:13:50]

Hi Jaro,

Small change here, but on Kraken it gives a 4Mb (2.15%) memory saving, and a
6.59% speed improvement for the instruction selector.

[Jarin, 2016-12-14 14:26:28]

Good catch! lgtm.

https://codereview.chromium.org/2572683005/diff/1/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/2572683005/diff/1/src/compiler/instruction.h#...
src/compiler/instruction.h:1159: void reserve(size_t size) {
fields_.reserve(size); }
style&naming nit: reserve -> ReserveSize

[Leszek Swirski, 2016-12-14 14:28:31]

On 2016/12/14 14:26:28, Jarin wrote:
> Good catch! lgtm.
> 
> https://codereview.chromium.org/2572683005/diff/1/src/compiler/instruction.h
> File src/compiler/instruction.h (right):
> 
>
https://codereview.chromium.org/2572683005/diff/1/src/compiler/instruction.h#...
> src/compiler/instruction.h:1159: void reserve(size_t size) {
> fields_.reserve(size); }
> style&naming nit: reserve -> ReserveSize

Done

[Leszek Swirski, 2016-12-14 14:28:34]

The CQ bit was checked by leszeks@chromium.org

[Leszek Swirski, 2016-12-14 14:28:34]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2572683005/#ps20001
(title: "Rename reserve to ReserveSize")

[commit-bot: I haz the power, 2016-12-14 14:28:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 14:54:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481725714413030,
"parent_rev": "7b0eb75181aa48f8b0c658216d374fb6556ea9f6", "commit_rev":
"5d61ec84837913ab754d4c1fa390fcf08579398b"}

[commit-bot: I haz the power, 2016-12-14 14:55:02]

Description was changed from

==========
[turbofan] Reserve the StateValueList's size before filling it

Avoid needless resizing of the StateValueList's fields vector by
reserving its (already known) size.
==========

to

==========
[turbofan] Reserve the StateValueList's size before filling it

Avoid needless resizing of the StateValueList's fields vector by
reserving its (already known) size.

Review-Url: https://codereview.chromium.org/2572683005
==========

[commit-bot: I haz the power, 2016-12-14 14:55:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 14:55:23]

Description was changed from

==========
[turbofan] Reserve the StateValueList's size before filling it

Avoid needless resizing of the StateValueList's fields vector by
reserving its (already known) size.

Review-Url: https://codereview.chromium.org/2572683005
==========

to

==========
[turbofan] Reserve the StateValueList's size before filling it

Avoid needless resizing of the StateValueList's fields vector by
reserving its (already known) size.

Committed: https://crrev.com/f3b7f21cbc774b3da784f9f22c2438421c289a8b
Cr-Commit-Position: refs/heads/master@{#41698}
==========

[commit-bot: I haz the power, 2016-12-14 14:55:23]

Patchset 2 (id:??) landed as
https://crrev.com/f3b7f21cbc774b3da784f9f22c2438421c289a8b
Cr-Commit-Position: refs/heads/master@{#41698}