Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2572633002: histograms: add missing VeyronEmmcUpgrade metrics (Closed)

Created:
4 years ago by vapier
Modified:
4 years ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

histograms: add missing VeyronEmmcUpgrade metrics These were added & used on the CrOS side, but not documented here. BUG=599960 Committed: https://crrev.com/c1fb475d9d1dfbd3be48401daecbf08dded9248e Cr-Commit-Position: refs/heads/master@{#438092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
vapier
posted a CL on the CrOS side to try and keep things in sync better ...
4 years ago (2016-12-12 23:08:07 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years ago (2016-12-12 23:28:00 UTC) #3
vapier
here's the CL on the CrOS side that added these new enum values: https://chromium-review.googlesource.com/342782
4 years ago (2016-12-12 23:34:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572633002/1
4 years ago (2016-12-12 23:35:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/354792)
4 years ago (2016-12-13 01:49:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572633002/1
4 years ago (2016-12-13 06:59:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 07:41:54 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 07:44:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1fb475d9d1dfbd3be48401daecbf08dded9248e
Cr-Commit-Position: refs/heads/master@{#438092}

Powered by Google App Engine
This is Rietveld 408576698