Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2572613002:
FaceDetection: Update overflow checking on Android (Closed)
DescriptionFaceDetection: Update overflow checking on Android
This CL removes upper limit for mojo sharedbuffer, and cleans up overflow
checking.
BUG=670309
Committed: https://crrev.com/8f68e974855e96a6a6c6bc484ea77da7df186595
Cr-Commit-Position: refs/heads/master@{#438252}
Patch Set 1 #
Messages
Total messages: 28 (20 generated)
The CQ bit was checked by xianglu@chromium.org to run a CQ dry run
mcasas@chromium.org changed reviewers: + mcasas@chromium.org
lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== FaceDetection: Update overflow checking on Android BUG=670309 ========== to ========== FaceDetection: Update overflow checking on Android This CL removes upper limit for mojo sharedbuffer, and cleans up overflow checking. BUG=670309 ==========
xianglu@chromium.org changed reviewers: - mcasas@chromium.org
xianglu@chromium.org changed reviewers: + dcheng@chromium.org
xianglu@chromium.org changed reviewers: + dtrainor@chromium.org - dcheng@chromium.org
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xianglu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
xianglu@chromium.org changed reviewers: + tsepez@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
reillyg@chromium.org changed reviewers: + reillyg@chromium.org
lgtm
lgtm
The CQ bit was checked by xianglu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481656859206960, "parent_rev":
"c318a0a619dff025698ccd97c957090c9f968c2b", "commit_rev":
"c310dc1ecea524412087e7ad4304080c2b5e7421"}
Message was sent while issue was closed.
Description was changed from ========== FaceDetection: Update overflow checking on Android This CL removes upper limit for mojo sharedbuffer, and cleans up overflow checking. BUG=670309 ========== to ========== FaceDetection: Update overflow checking on Android This CL removes upper limit for mojo sharedbuffer, and cleans up overflow checking. BUG=670309 Review-Url: https://codereview.chromium.org/2572613002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== FaceDetection: Update overflow checking on Android This CL removes upper limit for mojo sharedbuffer, and cleans up overflow checking. BUG=670309 Review-Url: https://codereview.chromium.org/2572613002 ========== to ========== FaceDetection: Update overflow checking on Android This CL removes upper limit for mojo sharedbuffer, and cleans up overflow checking. BUG=670309 Committed: https://crrev.com/8f68e974855e96a6a6c6bc484ea77da7df186595 Cr-Commit-Position: refs/heads/master@{#438252} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8f68e974855e96a6a6c6bc484ea77da7df186595 Cr-Commit-Position: refs/heads/master@{#438252} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
