Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2572583003: Check three times for the loading of the page. (Closed)

Created:
4 years ago by Olivier
Modified:
4 years ago
Reviewers:
gambard
CC:
chromium-reviews, stkhapugin, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check three times for the loading of the page. Check each second for the loading of the page. It must reach 25%, 50% then 75%. If one test fails, load distilled version. BUG=673658 Committed: https://crrev.com/632410c83c5807ebe8b970c0693b362d6b0b09a5 Cr-Commit-Position: refs/heads/master@{#438112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M ios/chrome/browser/reading_list/reading_list_web_state_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_web_state_observer.mm View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Olivier
4 years ago (2016-12-13 09:29:57 UTC) #6
gambard
lgtm
4 years ago (2016-12-13 09:42:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572583003/1
4 years ago (2016-12-13 09:57:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 10:03:17 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 10:03:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/632410c83c5807ebe8b970c0693b362d6b0b09a5
Cr-Commit-Position: refs/heads/master@{#438112}

Powered by Google App Engine
This is Rietveld 408576698