Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2572573002: Hook up make visible action for views (Closed)

Created:
4 years ago by David Tseng
Modified:
4 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up make visible action for views - try to scroll to the view's bounding rectangle when a client requests make visible - add switch as a checkbox (matched for that predicate) BUG=673048 Committed: https://crrev.com/350d83a296ebac88f8d25c0a19719bf803367900 Cr-Commit-Position: refs/heads/master@{#438082}

Patch Set 1 #

Patch Set 2 : Hook up make visible action for views #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/accessibility/ax_view_obj_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
David Tseng
4 years ago (2016-12-12 20:59:09 UTC) #4
dmazzoni
lgtm
4 years ago (2016-12-12 21:55:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572573002/20001
4 years ago (2016-12-12 22:21:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-12-13 00:24:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572573002/20001
4 years ago (2016-12-13 05:40:14 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 06:24:45 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-13 06:27:22 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/350d83a296ebac88f8d25c0a19719bf803367900
Cr-Commit-Position: refs/heads/master@{#438082}

Powered by Google App Engine
This is Rietveld 408576698