Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2572553002: Revert of Send crash dumps for odd ERR_CERT_DATE_INVALID cert errors (Closed)

Created:
4 years ago by estark
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Will Harris
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Send crash dumps for odd ERR_CERT_DATE_INVALID cert errors (patchset #5 id:80001 of https://codereview.chromium.org/2567643003/ ) Reason for revert: Turns out this issue is trivial to reproduce locally (I probably should have tried that first...) so diagnostic data from crash dumps isn't needed. Original issue's description: > Send crash dumps for odd ERR_CERT_DATE_INVALID cert errors > > Safe Browsing Extended Reporting reports show a number of certificate > errors from Windows users where the certificate error is > ERR_CERT_DATE_INVALID but the certificate chain appears to have > perfectly valid dates. > > To get some diagnostic data from Canary, this CL calls > DumpWithoutCrashing() when we observe such a chain. This CL is intended > to be reverted after obtaining a few days of data from Canary. > > BUG=672906 > > Committed: https://crrev.com/822fd5f5b3ab71603d34a376928bf05323abfd0b > Cr-Commit-Position: refs/heads/master@{#437726} TBR=rsleevi@chromium.org,wfh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=672906 Committed: https://crrev.com/ba0293aaab7ce154481fdca25e2eceff210da905 Cr-Commit-Position: refs/heads/master@{#437916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M net/cert/cert_verify_proc_win.cc View 3 chunks +0 lines, -56 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
estark
Created Revert of Send crash dumps for odd ERR_CERT_DATE_INVALID cert errors
4 years ago (2016-12-12 19:58:54 UTC) #2
Ryan Sleevi
lgtm
4 years ago (2016-12-12 19:59:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572553002/1
4 years ago (2016-12-12 20:00:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 21:29:36 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-12 21:32:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba0293aaab7ce154481fdca25e2eceff210da905
Cr-Commit-Position: refs/heads/master@{#437916}

Powered by Google App Engine
This is Rietveld 408576698