Add ChromeMostVisitedSitesFactory

Add ChromeMostVisitedSitesFactory

Move the popular sites factory next to it.

Currently PopularSites is explicitly not enabled (not even instantiated)
on desktop. We could in theory create it and let the field trial decide
whether to show tiles from it, but it really needs some work first for a
world where we use thumbnails instead of icons. Also, Desktop has its
own, separate mechanism for displaying default tiles baked into
TopSites.

BUG=655622
Committed: https://crrev.com/c35d272003f940ef2f2cd0c28466bd2063820928
Cr-Commit-Position: refs/heads/master@{#438472}

[sfiera, 2016-12-12 19:14:53]

sfiera@chromium.org changed reviewers:
+ bauerb@chromium.org

[sfiera, 2016-12-12 19:15:00]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 19:15:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 19:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 19:19:22]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[sfiera, 2016-12-13 09:51:54]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 09:52:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 10:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 10:34:42]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[sfiera, 2016-12-13 10:47:57]

Patchset #6 (id:100001) has been deleted

[sfiera, 2016-12-13 10:55:34]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 10:56:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 11:50:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 11:50:26]

Dry run: This issue passed the CQ dry run.

[sfiera, 2016-12-13 16:15:56]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 16:16:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-12-13 16:55:21]

lgtm

[sfiera, 2016-12-13 17:23:32]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[sfiera, 2016-12-13 17:23:33]

Thanks!

+treib; bauerb doesn't cover instant_service.cc

[commit-bot: I haz the power, 2016-12-13 17:24:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 17:24:00]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-12-13 17:27:15]

instant_service.cc lgtm

[sfiera, 2016-12-13 18:32:45]

Now that the webui has been submitting, using the factory there too. Will submit
in the morning, assuming dry run passes.

[sfiera, 2016-12-13 18:33:21]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 18:34:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 19:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 19:36:47]

Dry run: This issue passed the CQ dry run.

[sfiera, 2016-12-14 09:36:10]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-12-14 09:36:10]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2572533002/#ps160001
(title: "Use factory for webui")

[commit-bot: I haz the power, 2016-12-14 09:36:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 09:41:50]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1481708170229630,
"parent_rev": "a4f3c583fd56800f21c1f64e82a6f3b45eda711f", "commit_rev":
"314df2ddec75e727246e123ccbdcc0131c9d082f"}

[commit-bot: I haz the power, 2016-12-14 09:42:16]

Description was changed from

==========
Add ChromeMostVisitedSitesFactory

Move the popular sites factory next to it.

Currently PopularSites is explicitly not enabled (not even instantiated)
on desktop. We could in theory create it and let the field trial decide
whether to show tiles from it, but it really needs some work first for a
world where we use thumbnails instead of icons. Also, Desktop has its
own, separate mechanism for displaying default tiles baked into
TopSites.

BUG=655622
==========

to

==========
Add ChromeMostVisitedSitesFactory

Move the popular sites factory next to it.

Currently PopularSites is explicitly not enabled (not even instantiated)
on desktop. We could in theory create it and let the field trial decide
whether to show tiles from it, but it really needs some work first for a
world where we use thumbnails instead of icons. Also, Desktop has its
own, separate mechanism for displaying default tiles baked into
TopSites.

BUG=655622

Review-Url: https://codereview.chromium.org/2572533002
==========

[commit-bot: I haz the power, 2016-12-14 09:42:17]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2016-12-14 09:45:32]

Description was changed from

==========
Add ChromeMostVisitedSitesFactory

Move the popular sites factory next to it.

Currently PopularSites is explicitly not enabled (not even instantiated)
on desktop. We could in theory create it and let the field trial decide
whether to show tiles from it, but it really needs some work first for a
world where we use thumbnails instead of icons. Also, Desktop has its
own, separate mechanism for displaying default tiles baked into
TopSites.

BUG=655622

Review-Url: https://codereview.chromium.org/2572533002
==========

to

==========
Add ChromeMostVisitedSitesFactory

Move the popular sites factory next to it.

Currently PopularSites is explicitly not enabled (not even instantiated)
on desktop. We could in theory create it and let the field trial decide
whether to show tiles from it, but it really needs some work first for a
world where we use thumbnails instead of icons. Also, Desktop has its
own, separate mechanism for displaying default tiles baked into
TopSites.

BUG=655622

Committed: https://crrev.com/c35d272003f940ef2f2cd0c28466bd2063820928
Cr-Commit-Position: refs/heads/master@{#438472}
==========

[commit-bot: I haz the power, 2016-12-14 09:45:33]

Patchset 8 (id:??) landed as
https://crrev.com/c35d272003f940ef2f2cd0c28466bd2063820928
Cr-Commit-Position: refs/heads/master@{#438472}