Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2572503002: [OfflinePages] Renames StartProcessing to StartScheduledProcessing (Closed)

Created:
4 years ago by dougarnett
Modified:
4 years ago
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org, fgorski
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[OfflinePages] Renames StartProcessing to StartScheduledProcessing This is preparation for exposing new api for immediate procesing. BUG=672584 Committed: https://crrev.com/89245a01828af8afb9156c5fb95643d27ce283dc Cr-Commit-Position: refs/heads/master@{#438213}

Patch Set 1 #

Patch Set 2 : Fixed some comments #

Patch Set 3 : Fixed junit change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -72 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerProcessorImpl.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/interfaces/BackgroundSchedulerProcessor.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java View 1 7 chunks +16 lines, -15 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/background_scheduler_bridge.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/core/background/request_coordinator.h View 2 chunks +5 lines, -4 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/core/background/request_coordinator_unittest.cc View 1 14 chunks +33 lines, -29 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
dougarnett
4 years ago (2016-12-12 17:46:46 UTC) #5
Pete Williamson
lgtm
4 years ago (2016-12-12 19:43:03 UTC) #11
dougarnett
Think Pete's lgtm sufficient for this naming change so going to drop Filip as a ...
4 years ago (2016-12-12 21:13:08 UTC) #13
fgorski
lgtm
4 years ago (2016-12-12 21:16:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572503002/40001
4 years ago (2016-12-12 21:29:23 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/278171)
4 years ago (2016-12-13 01:37:19 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572503002/40001
4 years ago (2016-12-13 17:04:22 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-13 17:44:21 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-13 17:48:59 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/89245a01828af8afb9156c5fb95643d27ce283dc
Cr-Commit-Position: refs/heads/master@{#438213}

Powered by Google App Engine
This is Rietveld 408576698