Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2572483004:
Fix null pointer crash when VR code is not enabled (Closed)
DescriptionFix null pointer crash when VR code is not enabled
BUG=673644
Committed: https://crrev.com/00d18877a6617b4b9d705baa7e59fb5258e52f30
Cr-Commit-Position: refs/heads/master@{#438207}
Patch Set 1 #Patch Set 2 : remove unneccessary check #
Total comments: 2
Patch Set 3 : review #
Total comments: 2
Patch Set 4 : nit #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by bshe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix null pointer crash when VR code is not enabled BUG=673524 ========== to ========== Fix null pointer crash when VR code is not enabled BUG=673644 ==========
mthiesse@chromium.org changed reviewers: + mthiesse@chromium.org
https://codereview.chromium.org/2572483004/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java (right): https://codereview.chromium.org/2572483004/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:71: private boolean mCardboardSupportOnly; Default to true since it's only conditionally being set now.
The CQ bit was checked by bshe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2572483004/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java (right): https://codereview.chromium.org/2572483004/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:71: private boolean mCardboardSupportOnly; On 2016/12/13 16:45:42, mthiesse wrote: > Default to true since it's only conditionally being set now. Done.
lgtm https://codereview.chromium.org/2572483004/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java (right): https://codereview.chromium.org/2572483004/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:97: if (mVrDaydreamApi != null) mCardboardSupportOnly = !mVrDaydreamApi.isDaydreamReadyDevice(); nit: if (mVrDaydreamApi != null && mVrDaydreamApi.isDaydreamReadyDevice()) mCardboardSupportOnly = false;
https://codereview.chromium.org/2572483004/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java (right): https://codereview.chromium.org/2572483004/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:97: if (mVrDaydreamApi != null) mCardboardSupportOnly = !mVrDaydreamApi.isDaydreamReadyDevice(); On 2016/12/13 16:54:39, mthiesse wrote: > nit: > if (mVrDaydreamApi != null && mVrDaydreamApi.isDaydreamReadyDevice()) > mCardboardSupportOnly = false; Done.
The CQ bit was checked by bshe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mthiesse@chromium.org Link to the patchset: https://codereview.chromium.org/2572483004/#ps60001 (title: "nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix null pointer crash when VR code is not enabled BUG=673524 ========== to ========== Fix null pointer crash when VR code is not enabled BUG=673644 ==========
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481648578310360,
"parent_rev": "9db47ec83e13b1410a76ccc83ed99b5e3176308e", "commit_rev":
"b8faa5b53eeade2f5f17745ed3af4af4bcc4cdee"}
Message was sent while issue was closed.
Description was changed from ========== Fix null pointer crash when VR code is not enabled BUG=673644 ========== to ========== Fix null pointer crash when VR code is not enabled BUG=673644 Review-Url: https://codereview.chromium.org/2572483004 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Fix null pointer crash when VR code is not enabled BUG=673644 Review-Url: https://codereview.chromium.org/2572483004 ========== to ========== Fix null pointer crash when VR code is not enabled BUG=673644 Committed: https://crrev.com/00d18877a6617b4b9d705baa7e59fb5258e52f30 Cr-Commit-Position: refs/heads/master@{#438207} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/00d18877a6617b4b9d705baa7e59fb5258e52f30 Cr-Commit-Position: refs/heads/master@{#438207} |
