Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2572473002: gpu_fuzzer_angle: only run on Linux (Closed)

Created:
4 years ago by Corentin Wallez
Modified:
4 years ago
CC:
chromium-reviews, Geoff Lang, mmoroz, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu_fuzzer_angle: only run on Linux gl_context_egl isn't being compiled on Mac so we can't run the ANGLE GPU fuzzer on that platform. Ideally we would like to gate it on use_egl but this variable is only defined in ui/gl/BUILD.gn and not gpu/BUILD.gn. Gating the fuzzer on is_linux will not lose coverage as the code run is completely platform-independent. BUG=chromium:673276 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/689d5629cf7d5d23897fb99b847eaa0999289867 Cr-Commit-Position: refs/heads/master@{#438220}

Patch Set 1 #

Patch Set 2 : gpu_angle_fuzzer: only run on Linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M gpu/BUILD.gn View 1 1 chunk +17 lines, -15 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
Corentin Wallez
4 years ago (2016-12-12 15:41:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572473002/1
4 years ago (2016-12-12 15:41:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/197244)
4 years ago (2016-12-12 17:57:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572473002/1
4 years ago (2016-12-12 17:59:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/197294)
4 years ago (2016-12-12 21:50:41 UTC) #10
Corentin Wallez
Trying again, the test seems very flaky.
4 years ago (2016-12-12 22:26:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572473002/1
4 years ago (2016-12-12 22:33:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/197643)
4 years ago (2016-12-12 22:49:30 UTC) #17
Ken Russell (switch to Gerrit)
On 2016/12/12 22:26:25, Corentin Wallez wrote: > Trying again, the test seems very flaky. When ...
4 years ago (2016-12-13 01:35:55 UTC) #18
Ken Russell (switch to Gerrit)
On 2016/12/13 01:35:55, Ken Russell wrote: > On 2016/12/12 22:26:25, Corentin Wallez wrote: > > ...
4 years ago (2016-12-13 01:37:06 UTC) #19
Corentin Wallez
On 2016/12/13 at 01:37:06, kbr wrote: > On 2016/12/13 01:35:55, Ken Russell wrote: > > ...
4 years ago (2016-12-13 16:41:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572473002/20001
4 years ago (2016-12-13 16:41:48 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 17:54:51 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-13 17:58:22 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/689d5629cf7d5d23897fb99b847eaa0999289867
Cr-Commit-Position: refs/heads/master@{#438220}

Powered by Google App Engine
This is Rietveld 408576698