|
|
Chromium Code Reviews|
Created:
4 years ago by Corentin Wallez Modified:
4 years ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, Geoff Lang, mmoroz, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongpu_fuzzer_angle: only run on Linux
gl_context_egl isn't being compiled on Mac so we can't run the ANGLE GPU
fuzzer on that platform. Ideally we would like to gate it on use_egl but
this variable is only defined in ui/gl/BUILD.gn and not gpu/BUILD.gn.
Gating the fuzzer on is_linux will not lose coverage as the code run is
completely platform-independent.
BUG=chromium:673276
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/689d5629cf7d5d23897fb99b847eaa0999289867
Cr-Commit-Position: refs/heads/master@{#438220}
Patch Set 1 #Patch Set 2 : gpu_angle_fuzzer: only run on Linux #Messages
Total messages: 27 (13 generated)
Description was changed from ========== gpu_fuzzer_angle: only run on Linux gl_context_egl isn't being compiled on Mac so we can't run the ANGLE GPU fuzzer on that platform. Ideally we would like to gate it on use_egl but this variable is only defined in ui/gl/BUILD.gn and not gpu/BUILD.gn. Gating the fuzzer on is_linux will not lose coverage as the code run is completely platform-independent. BUG=chromium:673276 TBR=kbr@chromium.org ========== to ========== gpu_fuzzer_angle: only run on Linux gl_context_egl isn't being compiled on Mac so we can't run the ANGLE GPU fuzzer on that platform. Ideally we would like to gate it on use_egl but this variable is only defined in ui/gl/BUILD.gn and not gpu/BUILD.gn. Gating the fuzzer on is_linux will not lose coverage as the code run is completely platform-independent. BUG=chromium:673276 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by cwallez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by cwallez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by cwallez@chromium.org
The CQ bit was unchecked by cwallez@chromium.org
The CQ bit was checked by cwallez@chromium.org
Trying again, the test seems very flaky.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
On 2016/12/12 22:26:25, Corentin Wallez wrote: > Trying again, the test seems very flaky. When you see a flake like this, please first check the bug database and if a bug isn't filed about that test file a P1. Flaky tests are causing a lot of problems on the commit queue and they need to be dealt with aggressively.
On 2016/12/13 01:35:55, Ken Russell wrote: > On 2016/12/12 22:26:25, Corentin Wallez wrote: > > Trying again, the test seems very flaky. > > When you see a flake like this, please first check the bug database and if a bug > isn't filed about that test file a P1. Flaky tests are causing a lot of problems > on the commit queue and they need to be dealt with aggressively. Note, it looks like there's a patch failure in the latest try. Need to rebase?
On 2016/12/13 at 01:37:06, kbr wrote: > On 2016/12/13 01:35:55, Ken Russell wrote: > > On 2016/12/12 22:26:25, Corentin Wallez wrote: > > > Trying again, the test seems very flaky. > > > > When you see a flake like this, please first check the bug database and if a bug > > isn't filed about that test file a P1. Flaky tests are causing a lot of problems > > on the commit queue and they need to be dealt with aggressively. > > Note, it looks like there's a patch failure in the latest try. Need to rebase? Rebased, I should have known better than to hammer on the commit button. Here's the relevant bug, it seems fixed: https://bugs.chromium.org/p/chromium/issues/detail?id=673218
The CQ bit was checked by cwallez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481647266389630,
"parent_rev": "2467ea7307aeaa79209060c4b100d214fa157506", "commit_rev":
"abbb841b6e3f0f15219f466b4b049738e9b5d7b7"}
Message was sent while issue was closed.
Description was changed from ========== gpu_fuzzer_angle: only run on Linux gl_context_egl isn't being compiled on Mac so we can't run the ANGLE GPU fuzzer on that platform. Ideally we would like to gate it on use_egl but this variable is only defined in ui/gl/BUILD.gn and not gpu/BUILD.gn. Gating the fuzzer on is_linux will not lose coverage as the code run is completely platform-independent. BUG=chromium:673276 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu_fuzzer_angle: only run on Linux gl_context_egl isn't being compiled on Mac so we can't run the ANGLE GPU fuzzer on that platform. Ideally we would like to gate it on use_egl but this variable is only defined in ui/gl/BUILD.gn and not gpu/BUILD.gn. Gating the fuzzer on is_linux will not lose coverage as the code run is completely platform-independent. BUG=chromium:673276 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2572473002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== gpu_fuzzer_angle: only run on Linux gl_context_egl isn't being compiled on Mac so we can't run the ANGLE GPU fuzzer on that platform. Ideally we would like to gate it on use_egl but this variable is only defined in ui/gl/BUILD.gn and not gpu/BUILD.gn. Gating the fuzzer on is_linux will not lose coverage as the code run is completely platform-independent. BUG=chromium:673276 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2572473002 ========== to ========== gpu_fuzzer_angle: only run on Linux gl_context_egl isn't being compiled on Mac so we can't run the ANGLE GPU fuzzer on that platform. Ideally we would like to gate it on use_egl but this variable is only defined in ui/gl/BUILD.gn and not gpu/BUILD.gn. Gating the fuzzer on is_linux will not lose coverage as the code run is completely platform-independent. BUG=chromium:673276 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/689d5629cf7d5d23897fb99b847eaa0999289867 Cr-Commit-Position: refs/heads/master@{#438220} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/689d5629cf7d5d23897fb99b847eaa0999289867 Cr-Commit-Position: refs/heads/master@{#438220} |
