Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2572453002: [PlzNavigate] Wire page visibility info to navigation requests (Closed)

Created:
4 years ago by droger
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, creis+watch_chromium.org, tburkard+watch_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), gavinp+prer_chromium.org, darin-cc_chromium.org, loading-reviews_chromium.org, mmenke, mattcary, pasko
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PlzNavigate] Wire page visibility info to navigation requests BUG=668714 TBR=jochen CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/f8579b7d7bd148269648d2e5cf469a57e524fcfa Cr-Commit-Position: refs/heads/master@{#438142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_request_info.h View 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_request_info.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/loader/navigation_url_loader_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
droger
Please take a look. Is there anything more I need to do to test with ...
4 years ago (2016-12-12 15:48:04 UTC) #7
droger
CC mattcary, pasko
4 years ago (2016-12-13 11:58:15 UTC) #10
clamy
Thanks! Lgtm.
4 years ago (2016-12-13 12:07:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572453002/20001
4 years ago (2016-12-13 12:11:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/324675)
4 years ago (2016-12-13 12:17:24 UTC) #15
droger
TBR=jochen for the new DEPS on WebPageVisibilityState.h
4 years ago (2016-12-13 12:22:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572453002/20001
4 years ago (2016-12-13 12:22:44 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-13 12:27:30 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-13 12:29:49 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8579b7d7bd148269648d2e5cf469a57e524fcfa
Cr-Commit-Position: refs/heads/master@{#438142}

Powered by Google App Engine
This is Rietveld 408576698