Issue 257243003: Revert 266932 "GN build improvements."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257243003: Revert 266932 "GN build improvements." (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 266932 "GN build improvements." > GN build improvements. > > Fixes a TODO about private symbols on GCC. > > Moves many third party BUILD.gn files from the secondary tree to the main one. > > Fixes the dependencies on Linux so "gn check" passes again. > > BUG=367595 > R=scottmg@chromium.org > > Review URL: https://codereview.chromium.org/256153003 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266933

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-5 lines, -474 lines)			Patch
M	trunk/src/components/translate/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/net/third_party/nss/ssl/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	trunk/src/third_party/expat/BUILD.gn	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	trunk/src/third_party/libevent/BUILD.gn	View	1 chunk	+0 lines, -45 lines	0 comments	Download
D	trunk/src/third_party/libxml/BUILD.gn	View	1 chunk	+0 lines, -190 lines	0 comments	Download
D	trunk/src/third_party/mach_override/BUILD.gn	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	trunk/src/third_party/snappy/BUILD.gn	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	trunk/src/third_party/wtl/BUILD.gn	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	trunk/src/third_party/zlib/BUILD.gn	View	1 chunk	+0 lines, -102 lines	0 comments	Download
A +	trunk/src/tools/gn/secondary/third_party/expat/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/tools/gn/secondary/third_party/libevent/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/tools/gn/secondary/third_party/libxml/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/tools/gn/secondary/third_party/mach_override/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/tools/gn/secondary/third_party/snappy/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/tools/gn/secondary/third_party/wtl/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/tools/gn/secondary/third_party/zlib/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/ui/events/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/ui/gfx/BUILD.gn	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r266933.

Expand Messages | Collapse Messages