Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256153003: GN build improvements. (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org, tdresser+watch_chromium.org
Visibility:
Public.

Description

GN build improvements. Fixes a TODO about private symbols on GCC. Moves many third party BUILD.gn files from the secondary tree to the main one. Fixes the dependencies on Linux so "gn check" passes again. BUG=367595 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266932

Patch Set 1 #

Patch Set 2 : fixewas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -501 lines) Patch
M components/translate/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M crypto/BUILD.gn View 1 1 chunk +0 lines, -6 lines 0 comments Download
M net/BUILD.gn View 1 3 chunks +35 lines, -27 lines 0 comments Download
M net/third_party/nss/ssl/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/expat/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/libevent/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libxml/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mach_override/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/snappy/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/wtl/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/zlib/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/gn/secondary/third_party/expat/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/gn/secondary/third_party/libevent/BUILD.gn View 1 chunk +0 lines, -45 lines 0 comments Download
D tools/gn/secondary/third_party/libxml/BUILD.gn View 1 chunk +0 lines, -190 lines 0 comments Download
D tools/gn/secondary/third_party/mach_override/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/gn/secondary/third_party/snappy/BUILD.gn View 1 chunk +0 lines, -46 lines 0 comments Download
D tools/gn/secondary/third_party/wtl/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/gn/secondary/third_party/zlib/BUILD.gn View 1 chunk +0 lines, -102 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 7 months ago (2014-04-28 17:56:28 UTC) #1
scottmg
lgtm
6 years, 7 months ago (2014-04-28 18:03:46 UTC) #2
tfarina
Brett, I added 367595 to the CL description.
6 years, 7 months ago (2014-04-28 18:17:17 UTC) #3
brettw
6 years, 7 months ago (2014-04-29 19:14:03 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r266932.

Powered by Google App Engine
This is Rietveld 408576698