Issue 2572413002: Ash magnifier: Check whether the caret bounds were actually moved or not.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2572413002: Ash magnifier: Check whether the caret bounds were actually moved or not. (Closed)

Created:
4 years ago by kinaba

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Ash magnifier: Check whether the caret bounds were actually moved or not. If the caret bounds were not actually moved, do not move the magnification window. Otherwise it causes unnecessary move of focuses. BUG=673200 TEST=MagnificationControllerTest Review-Url: https://codereview.chromium.org/2562273002 Cr-Commit-Position: refs/heads/master@{#438347} (cherry picked from commit c0105686d120fe7978122cf399061c738de15134) Committed: https://chromium.googlesource.com/chromium/src/+/c8221d1bf74e1b1951322795f93b1fc93a62044e

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	ash/magnifier/magnification_controller.cc	View		1 chunk	+10 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

kinaba

4 years ago (2016-12-15 04:07:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c8221d1bf74e1b1951322795f93b1fc93a62044e.