Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2572393002: Fix crashes in TracingBrowserTest.TestMemoryInfra (Closed)

Created:
4 years ago by ssid
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crashes in TracingBrowserTest.TestMemoryInfra The test may fail if the tracing is stopped before any of the memory dumps are finished. Now it triggers an explicit memory dump and waits till it is finished. BUG=658054 Committed: https://crrev.com/a5b1973c322a9e6bc33dc4a8a2397e8df75d4b4c Cr-Commit-Position: refs/heads/master@{#439893}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -19 lines) Patch
M chrome/test/base/tracing.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/test/base/tracing.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/test/base/tracing_browsertest.cc View 4 chunks +36 lines, -15 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
ssid
ptal thanks
4 years ago (2016-12-15 04:44:25 UTC) #8
Primiano Tucci (use gerrit)
thanks, LGTM
4 years ago (2016-12-20 19:29:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572393002/40001
4 years ago (2016-12-20 22:19:48 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-12-20 22:27:35 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-20 22:30:18 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5b1973c322a9e6bc33dc4a8a2397e8df75d4b4c
Cr-Commit-Position: refs/heads/master@{#439893}

Powered by Google App Engine
This is Rietveld 408576698