Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2572383002: Remove fast/forms/associatedFormControls-leak-nodes.html. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fast/forms/associatedFormControls-leak-nodes.html. It is a test for a Document leak by Document::m_associatedFormControls [1]. However [2] removed m_associatedFormControls, and now the test isn't helpful. [1] https://chromium.googlesource.com/chromium/src/+/ca06c84dc478d4af2aa0b37026da6fa1a679d02e [2] https://chromium.googlesource.com/chromium/src/+/c7e3c1f85c4691489409104d9ab53d30b52cd8d9 BUG=674194 Committed: https://crrev.com/ded565026e554a3df1623475c68885bf86c650ba Cr-Commit-Position: refs/heads/master@{#438751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
D third_party/WebKit/LayoutTests/fast/forms/associatedFormControls-leak-nodes.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/associatedFormControls-leak-nodes-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tkent
kouhei@, would you review this please?
4 years ago (2016-12-15 02:11:13 UTC) #2
kouhei (in TOK)
lgtm
4 years ago (2016-12-15 04:24:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572383002/1
4 years ago (2016-12-15 04:24:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 05:07:18 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 05:10:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ded565026e554a3df1623475c68885bf86c650ba
Cr-Commit-Position: refs/heads/master@{#438751}

Powered by Google App Engine
This is Rietveld 408576698