Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2572333003: Import wpt@4970d7334aaf8977c5b617075aa48be1b6e482c7 (Closed)

Created:
4 years ago by qyearsley
Modified:
4 years ago
Reviewers:
tkent, foolip
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, dcheng, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import wpt@4970d7334aaf8977c5b617075aa48be1b6e482c7 Using update-w3c-deps in Chromium 0e1205a90260eee71b8cab3cb48f90b0eca67cc7. Manual import. Committed: https://crrev.com/2b7b4a5dccd5e71869e87cfd11f70fddabd047f3 Cr-Commit-Position: refs/heads/master@{#439349}

Patch Set 1 #

Patch Set 2 : Manually udpate expectations and baseline #

Patch Set 3 : webkit-patch rebaseline-cl #

Patch Set 4 : Add timeout expectation #

Patch Set 5 : Update TestExpectations #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1049 lines, -277 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 2 chunks +13 lines, -6 lines 1 comment Download
M third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json View 1 2 3 4 11 chunks +96 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/README.md View 1 2 3 4 2 chunks +24 lines, -14 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/auxclick/auxclick_event-manual.html View 1 2 3 4 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/clear-site-data/navigation.html View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/clear-site-data/support/echo-clear-site-data.py View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/clear-site-data/support/test_utils.js View 1 2 3 4 1 chunk +89 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/historical.html View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/historical-expected.txt View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-exit-fullscreen-manual.html View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-exit-fullscreen-twice-manual.html View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-exit-fullscreen-twice-manual-expected.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-fullscreen-element-manual.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-fullscreen-element-manual-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-fullscreen-enabled.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-fullscreen-enabled-active-document.html View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-onfullscreenchange-manual.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-onfullscreenerror.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-fullscreen-element-sibling-manual.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-move-manual.html View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-move-manual-expected.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-move-to-iframe-manual.html View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-move-to-iframe-manual-expected.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-remove-iframe-manual.html View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-remove-iframe-manual-expected.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-remove-manual.html View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-remove-manual-expected.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-manual.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-non-top-manual.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-not-allowed.html View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-same-manual.html View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-svg-rect-manual.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-svg-svg-manual.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-top-manual.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-twice-manual.html View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-twice-manual-expected.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-two-elements-manual.html View 1 2 3 4 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-two-elements-manual-expected.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-two-iframes-manual.html View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/historical.html View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/historical-expected.txt View 1 2 3 4 1 chunk +87 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/editing/dnd/canvas/cross-domain/001.xhtml View 1 2 3 4 1 chunk +0 lines, -59 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/html/editing/dnd/canvas/cross-domain/001.manual.xhtml View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/editing/dnd/cross-document/002.html View 1 2 3 4 1 chunk +0 lines, -25 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/html/editing/dnd/cross-document/002.manual.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/editing/dnd/images/cross-domain/001.xhtml View 1 2 3 4 1 chunk +0 lines, -49 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/html/editing/dnd/images/cross-domain/001.manual.xhtml View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_boundary_events_in_capturing-manual.html View 1 2 3 4 1 chunk +97 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_gotpointercapture_before_first_pointerevent-manual.html View 1 2 3 4 1 chunk +0 lines, -97 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_support.js View 1 2 3 4 3 chunks +7 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/workers/opaque-origin.html View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/workers/support/sandboxed-tests.html View 1 2 3 4 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
qyearsley
(Automatic import is currently blocked on http://crbug.com/674692.)
4 years ago (2016-12-16 01:13:36 UTC) #4
tkent
Tests are still failing.
4 years ago (2016-12-16 02:42:09 UTC) #5
qyearsley
Now passing. https://codereview.chromium.org/2572333003/diff/40001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2572333003/diff/40001/third_party/WebKit/LayoutTests/TestExpectations#newcode1850 third_party/WebKit/LayoutTests/TestExpectations:1850: crbug.com/626703 imported/wpt/workers/opaque-origin.html [ Timeout Crash ] This ...
4 years ago (2016-12-17 18:59:27 UTC) #16
foolip
lgtm
4 years ago (2016-12-17 19:23:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572333003/40001
4 years ago (2016-12-17 19:23:45 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:40001)
4 years ago (2016-12-17 19:28:36 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-17 19:30:59 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2b7b4a5dccd5e71869e87cfd11f70fddabd047f3
Cr-Commit-Position: refs/heads/master@{#439349}

Powered by Google App Engine
This is Rietveld 408576698