Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2572293002: More unique_ptr returns from DIB methods. (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : win build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -45 lines) Patch
M core/fxge/dib/fx_dib_main.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M core/fxge/dib/fx_dib_transform.cpp View 3 chunks +15 lines, -14 lines 0 comments Download
M core/fxge/fx_dib.h View 3 chunks +4 lines, -6 lines 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 3 chunks +3 lines, -6 lines 0 comments Download
M core/fxge/win32/fx_win32_print.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxgraphics/cfx_graphics.cpp View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Tom Sepez
Dan, for review.
4 years ago (2016-12-14 22:22:00 UTC) #4
dsinclair
lgtm
4 years ago (2016-12-15 03:48:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572293002/20001
4 years ago (2016-12-15 03:48:32 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 03:48:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/b8642f8a3c3a6d359c4e319b8ba91f8df644...

Powered by Google App Engine
This is Rietveld 408576698