Return unique_ptr from GetAlphaMask.

Return unique_ptr from GetAlphaMask.

Rename GetAlphaMask => CloneAlphaMask since it does more than get.
Rename CopyAlphaMask => SetAlphaMask, as it copies IN, not OUT.
ditto for CopyPalette => SetPalette.

BUG=

Review-Url: https://codereview.chromium.org/2572243002
Committed: https://pdfium.googlesource.com/pdfium/+/72c1bda4efaf0121e13b794cb886acd9806b6c89

[Tom Sepez, 2016-12-14 21:18:42]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 21:18:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-14 21:27:15]

Description was changed from

==========
Return unique_ptr from GetAlphaMask.

Rename GetAlphaMask => CloneAlphaMask.
Rename CopyAlphaMask => SetAlphaMask, as it copies IN. not OUT.
ditto for CopyPalette => SetPalette.

BUG=
==========

to

==========
Return unique_ptr from GetAlphaMask.

Rename GetAlphaMask => CloneAlphaMask since it does more than get.
Rename CopyAlphaMask => SetAlphaMask, as it copies IN. not OUT.
ditto for CopyPalette => SetPalette.

BUG=
==========

[Tom Sepez, 2016-12-14 21:27:15]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-12-14 21:27:30]

Description was changed from

==========
Return unique_ptr from GetAlphaMask.

Rename GetAlphaMask => CloneAlphaMask since it does more than get.
Rename CopyAlphaMask => SetAlphaMask, as it copies IN. not OUT.
ditto for CopyPalette => SetPalette.

BUG=
==========

to

==========
Return unique_ptr from GetAlphaMask.

Rename GetAlphaMask => CloneAlphaMask since it does more than get.
Rename CopyAlphaMask => SetAlphaMask, as it copies IN, not OUT.
ditto for CopyPalette => SetPalette.

BUG=
==========

[Tom Sepez, 2016-12-14 21:31:43]

Dan, for review.

https://codereview.chromium.org/2572243002/diff/1/core/fxge/dib/fx_dib_conver...
File core/fxge/dib/fx_dib_convert.cpp (right):

https://codereview.chromium.org/2572243002/diff/1/core/fxge/dib/fx_dib_conver...
core/fxge/dib/fx_dib_convert.cpp:871: pAlphaMask = CloneAlphaMask().release();
battle for another day ...

[commit-bot: I haz the power, 2016-12-14 21:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 21:34:19]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-14 21:39:05]

lgtm w/ nits.

https://codereview.chromium.org/2572243002/diff/1/core/fxge/dib/fx_dib_main.cpp
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/2572243002/diff/1/core/fxge/dib/fx_dib_main.c...
core/fxge/dib/fx_dib_main.cpp:623: uint8_t* dest_scan =
(uint8_t*)pMask->GetScanline(row - rect.top);
nit: static_cast

https://codereview.chromium.org/2572243002/diff/1/core/fxge/dib/fx_dib_main.c...
core/fxge/dib/fx_dib_main.cpp:652: for (int row = 0; row < m_Height; row++)
nit: {}s

https://codereview.chromium.org/2572243002/diff/1/core/fxge/dib/fx_dib_main.c...
core/fxge/dib/fx_dib_main.cpp:653:
FXSYS_memcpy((void*)m_pAlphaMask->GetScanline(row),
static_cast?

[Tom Sepez, 2016-12-14 22:01:51]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-12-14 22:01:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2572243002/#ps20001
(title: "rebase, nits, typo.")

[commit-bot: I haz the power, 2016-12-14 22:02:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-14 22:05:05]

https://codereview.chromium.org/2572243002/diff/1/core/fxge/dib/fx_dib_main.cpp
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/2572243002/diff/1/core/fxge/dib/fx_dib_main.c...
core/fxge/dib/fx_dib_main.cpp:623: uint8_t* dest_scan =
(uint8_t*)pMask->GetScanline(row - rect.top);
On 2016/12/14 21:39:05, dsinclair wrote:
> nit: static_cast
Actually, both of these are const_casts.
Done.

https://codereview.chromium.org/2572243002/diff/1/core/fxge/dib/fx_dib_main.c...
core/fxge/dib/fx_dib_main.cpp:652: for (int row = 0; row < m_Height; row++)
On 2016/12/14 21:39:05, dsinclair wrote:
> nit: {}s

much better. done.

[commit-bot: I haz the power, 2016-12-14 22:15:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481752911090750,
"parent_rev": "5e4388ef805b1666a1064e4dc73f4f1e792aa041", "commit_rev":
"72c1bda4efaf0121e13b794cb886acd9806b6c89"}

[commit-bot: I haz the power, 2016-12-14 22:15:16]

Description was changed from

==========
Return unique_ptr from GetAlphaMask.

Rename GetAlphaMask => CloneAlphaMask since it does more than get.
Rename CopyAlphaMask => SetAlphaMask, as it copies IN, not OUT.
ditto for CopyPalette => SetPalette.

BUG=
==========

to

==========
Return unique_ptr from GetAlphaMask.

Rename GetAlphaMask => CloneAlphaMask since it does more than get.
Rename CopyAlphaMask => SetAlphaMask, as it copies IN, not OUT.
ditto for CopyPalette => SetPalette.

BUG=

Review-Url: https://codereview.chromium.org/2572243002
Committed:
https://pdfium.googlesource.com/pdfium/+/72c1bda4efaf0121e13b794cb886acd9806b...
==========

[commit-bot: I haz the power, 2016-12-14 22:15:17]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/72c1bda4efaf0121e13b794cb886acd9806b...