Issue 25722004: Move core/platform/midi to modules/webmidi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25722004: Move core/platform/midi to modules/webmidi (Closed)

Created:
7 years, 2 months ago by abarth-chromium

Modified:
7 years, 2 months ago

Reviewers:
eseidel

CC:
blink-reviews, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move core/platform/midi to modules/webmidi There doesn't seem to be any reason for this code to be in the platform directory. We might as well move it to the webmidi module next to the code that uses it. R=eseidel BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158753

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -212 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	Source/core/platform/midi/MIDIAccessor.h	View	1 chunk	+0 lines, -67 lines	0 comments	Download
D	Source/core/platform/midi/MIDIAccessor.cpp	View	1 chunk	+0 lines, -89 lines	0 comments	Download
D	Source/core/platform/midi/MIDIAccessorClient.h	View	1 chunk	+0 lines, -49 lines	0 comments	Download
D	Source/core/platform/midi/OWNERS	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/modules.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/modules/webmidi/MIDIAccess.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	Source/modules/webmidi/MIDIAccessor.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	Source/modules/webmidi/MIDIAccessor.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	Source/modules/webmidi/MIDIAccessorClient.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25722004/1

7 years, 2 months ago (2013-10-02 17:48:46 UTC) #3

Message was sent while issue was closed.

Change committed as 158753

Expand Messages | Collapse Messages