Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2572143002:
Disable partition allocation on iOS. (Closed)
DescriptionDisable partition allocation on iOS.
The partition allocation unittests fails with a CHECK(!ret) in
setSystemPagesInaccessible when the mprotect call returns
with EINVAL.
BUG=None
Committed: https://crrev.com/bd37e3b0c0d557ba1fc1f8c36683e879c085bf28
Cr-Commit-Position: refs/heads/master@{#438571}
Patch Set 1 #
Messages
Total messages: 27 (16 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Disable partition allocation on iOS. The partition allocation unittests fails with a CHECK(!ret) in setSystemPagesInaccessible when run on a device as mprotect is not available on devices (returns EPERM). BUG=None ========== to ========== Disable partition allocation on iOS. The partition allocation unittests fails with a CHECK(!ret) in setSystemPagesInaccessible when the mprotect call returns with EINVAL. BUG=None ==========
sdefresne@chromium.org changed reviewers: + dcheng@chromium.org
sdefresne@chromium.org changed reviewers: + rohitrao@chromium.org
rohitrao/dcheng: can you both take a look?
This causes all the downstream device bots to fail with the following: [ RUN ] PartitionAllocTest.Basic [72203:2567:1214/062024.984903:191640344358919:FATAL:page_allocator.cc(199)] Check failed: !ret.
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dcheng@chromium.org changed reviewers: + palmer@chromium.org
+palmer, do we ever expect to use PA on ios?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/12/14 17:20:49, dcheng wrote: > +palmer, do we ever expect to use PA on ios? For reference, it was part of blink and moved to base/. As iOS has never built blink, this has never been tested/used before on iOS.
LGTM
To answer dcheng's question: Perhaps, someday. But we'll fix the problem that day, rather than today. :)
lgtm
The CQ bit was checked by rohitrao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481739733891930, "parent_rev":
"21c54d142b2a30c043b31e2dd513ca98b1f0dd4c", "commit_rev":
"7d69f7322acdb17b933346853698408c8300e96b"}
Message was sent while issue was closed.
Description was changed from ========== Disable partition allocation on iOS. The partition allocation unittests fails with a CHECK(!ret) in setSystemPagesInaccessible when the mprotect call returns with EINVAL. BUG=None ========== to ========== Disable partition allocation on iOS. The partition allocation unittests fails with a CHECK(!ret) in setSystemPagesInaccessible when the mprotect call returns with EINVAL. BUG=None Review-Url: https://codereview.chromium.org/2572143002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable partition allocation on iOS. The partition allocation unittests fails with a CHECK(!ret) in setSystemPagesInaccessible when the mprotect call returns with EINVAL. BUG=None Review-Url: https://codereview.chromium.org/2572143002 ========== to ========== Disable partition allocation on iOS. The partition allocation unittests fails with a CHECK(!ret) in setSystemPagesInaccessible when the mprotect call returns with EINVAL. BUG=None Committed: https://crrev.com/bd37e3b0c0d557ba1fc1f8c36683e879c085bf28 Cr-Commit-Position: refs/heads/master@{#438571} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bd37e3b0c0d557ba1fc1f8c36683e879c085bf28 Cr-Commit-Position: refs/heads/master@{#438571}
Message was sent while issue was closed.
On 2016/12/14 19:11:04, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/bd37e3b0c0d557ba1fc1f8c36683e879c085bf28 > Cr-Commit-Position: refs/heads/master@{#438571} Thank you both for the quick review and for sending the CL to CQ. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
