Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2572133003:
[ash-md] Doesn't close VPN menu when connecting to a VPN (Closed)
|
Created:
4 years ago by varkha Modified:
4 years ago Reviewers:
tdanderson CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ash-md] Doesn't close VPN menu when connecting to a VPN
BUG=646698
Committed: https://crrev.com/9f7a8c744a3416bafbaf3af546d59da742fe3838
Cr-Commit-Position: refs/heads/master@{#438635}
Patch Set 1 #
Messages
Total messages: 18 (13 generated)
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
varkha@chromium.org changed reviewers: + tdanderson@chromium.org
tdanderson@, PTAL - separated this for M-57. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, thanks
The CQ bit was checked by varkha@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481751354865150, "parent_rev":
"43c85ef94a7952b1974717a18d49676fe1dcae93", "commit_rev":
"dc71bc7bbd8be46a2911da58d1ebf892b2cea969"}
Message was sent while issue was closed.
Description was changed from ========== [ash-md] Doesn't close VPN menu when connecting to a VPN BUG=646698 ========== to ========== [ash-md] Doesn't close VPN menu when connecting to a VPN BUG=646698 Review-Url: https://codereview.chromium.org/2572133003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [ash-md] Doesn't close VPN menu when connecting to a VPN BUG=646698 Review-Url: https://codereview.chromium.org/2572133003 ========== to ========== [ash-md] Doesn't close VPN menu when connecting to a VPN BUG=646698 Committed: https://crrev.com/9f7a8c744a3416bafbaf3af546d59da742fe3838 Cr-Commit-Position: refs/heads/master@{#438635} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9f7a8c744a3416bafbaf3af546d59da742fe3838 Cr-Commit-Position: refs/heads/master@{#438635} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
