Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3231)

Unified Diff: chrome/browser/ui/webui/ntp_tiles_internals_ui.cc

Issue 2572133002: Add more features to ntp-tiles-internal (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
diff --git a/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc b/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
index 6f705979b20d9278f3988bafb3819b7747c2334b..ba5a46b84795256f243d6d7c9d447823f29a30b7 100644
--- a/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
+++ b/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
@@ -9,7 +9,6 @@
#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/history/top_sites_factory.h"
#include "chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.h"
-#include "chrome/browser/ntp_tiles/chrome_popular_sites_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search/suggestions/image_decoder_impl.h"
#include "chrome/browser/search/suggestions/suggestions_service_factory.h"
@@ -42,9 +41,8 @@ class ChromeNTPTilesInternalsMessageHandlerClient
void RegisterMessages() override;
// ntp_tiles::NTPTilesInternalsMessageHandlerClient
- bool DoesSourceExist(ntp_tiles::NTPTileSource source) override;
+ base::SequencedWorkerPool* GetBlockingPool() override;
std::unique_ptr<ntp_tiles::MostVisitedSites> MakeMostVisitedSites() override;
- std::unique_ptr<ntp_tiles::PopularSites> MakePopularSites() override;
PrefService* GetPrefs() override;
void RegisterMessageCallback(
const std::string& message,
@@ -62,22 +60,9 @@ void ChromeNTPTilesInternalsMessageHandlerClient::RegisterMessages() {
handler_.RegisterMessages(this);
}
-bool ChromeNTPTilesInternalsMessageHandlerClient::DoesSourceExist(
- ntp_tiles::NTPTileSource source) {
- switch (source) {
- case ntp_tiles::NTPTileSource::TOP_SITES:
- case ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE:
- case ntp_tiles::NTPTileSource::WHITELIST:
- return true;
- case ntp_tiles::NTPTileSource::POPULAR:
-#if defined(OS_ANDROID)
- return true;
-#else
- return false;
-#endif
- }
- NOTREACHED();
- return false;
+base::SequencedWorkerPool*
+ChromeNTPTilesInternalsMessageHandlerClient::GetBlockingPool() {
+ return content::BrowserThread::GetBlockingPool();
}
std::unique_ptr<ntp_tiles::MostVisitedSites>
@@ -86,15 +71,6 @@ ChromeNTPTilesInternalsMessageHandlerClient::MakeMostVisitedSites() {
Profile::FromWebUI(web_ui()));
}
-std::unique_ptr<ntp_tiles::PopularSites>
-ChromeNTPTilesInternalsMessageHandlerClient::MakePopularSites() {
-#if defined(OS_ANDROID)
- return ChromePopularSitesFactory::NewForProfile(Profile::FromWebUI(web_ui()));
-#else
- return nullptr;
-#endif
-}
-
PrefService* ChromeNTPTilesInternalsMessageHandlerClient::GetPrefs() {
return Profile::FromWebUI(web_ui())->GetPrefs();
}

Powered by Google App Engine
This is Rietveld 408576698