Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/ui/webui/ntp_tiles_internals_ui.cc

Issue 2572133002: Add more features to ntp-tiles-internal (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/ntp_tiles_internals_ui.h" 5 #include "chrome/browser/ui/webui/ntp_tiles_internals_ui.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "chrome/browser/favicon/favicon_service_factory.h" 9 #include "chrome/browser/favicon/favicon_service_factory.h"
10 #include "chrome/browser/history/top_sites_factory.h" 10 #include "chrome/browser/history/top_sites_factory.h"
11 #include "chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.h" 11 #include "chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.h"
12 #include "chrome/browser/ntp_tiles/chrome_popular_sites_factory.h"
13 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/search/suggestions/image_decoder_impl.h" 13 #include "chrome/browser/search/suggestions/image_decoder_impl.h"
15 #include "chrome/browser/search/suggestions/suggestions_service_factory.h" 14 #include "chrome/browser/search/suggestions/suggestions_service_factory.h"
16 #include "chrome/browser/search_engines/template_url_service_factory.h" 15 #include "chrome/browser/search_engines/template_url_service_factory.h"
17 #include "chrome/common/url_constants.h" 16 #include "chrome/common/url_constants.h"
18 #include "components/grit/components_resources.h" 17 #include "components/grit/components_resources.h"
19 #include "components/history/core/browser/top_sites.h" 18 #include "components/history/core/browser/top_sites.h"
20 #include "components/image_fetcher/image_fetcher_impl.h" 19 #include "components/image_fetcher/image_fetcher_impl.h"
21 #include "components/ntp_tiles/field_trial.h" 20 #include "components/ntp_tiles/field_trial.h"
22 #include "components/ntp_tiles/icon_cacher.h" 21 #include "components/ntp_tiles/icon_cacher.h"
(...skipping 12 matching lines...) Expand all
35 : public content::WebUIMessageHandler, 34 : public content::WebUIMessageHandler,
36 public ntp_tiles::NTPTilesInternalsMessageHandlerClient { 35 public ntp_tiles::NTPTilesInternalsMessageHandlerClient {
37 public: 36 public:
38 ChromeNTPTilesInternalsMessageHandlerClient() {} 37 ChromeNTPTilesInternalsMessageHandlerClient() {}
39 38
40 private: 39 private:
41 // content::WebUIMessageHandler: 40 // content::WebUIMessageHandler:
42 void RegisterMessages() override; 41 void RegisterMessages() override;
43 42
44 // ntp_tiles::NTPTilesInternalsMessageHandlerClient 43 // ntp_tiles::NTPTilesInternalsMessageHandlerClient
45 bool DoesSourceExist(ntp_tiles::NTPTileSource source) override; 44 base::SequencedWorkerPool* GetBlockingPool() override;
46 std::unique_ptr<ntp_tiles::MostVisitedSites> MakeMostVisitedSites() override; 45 std::unique_ptr<ntp_tiles::MostVisitedSites> MakeMostVisitedSites() override;
47 std::unique_ptr<ntp_tiles::PopularSites> MakePopularSites() override;
48 PrefService* GetPrefs() override; 46 PrefService* GetPrefs() override;
49 void RegisterMessageCallback( 47 void RegisterMessageCallback(
50 const std::string& message, 48 const std::string& message,
51 const base::Callback<void(const base::ListValue*)>& callback) override; 49 const base::Callback<void(const base::ListValue*)>& callback) override;
52 void CallJavascriptFunctionVector( 50 void CallJavascriptFunctionVector(
53 const std::string& name, 51 const std::string& name,
54 const std::vector<const base::Value*>& values) override; 52 const std::vector<const base::Value*>& values) override;
55 53
56 ntp_tiles::NTPTilesInternalsMessageHandler handler_; 54 ntp_tiles::NTPTilesInternalsMessageHandler handler_;
57 55
58 DISALLOW_COPY_AND_ASSIGN(ChromeNTPTilesInternalsMessageHandlerClient); 56 DISALLOW_COPY_AND_ASSIGN(ChromeNTPTilesInternalsMessageHandlerClient);
59 }; 57 };
60 58
61 void ChromeNTPTilesInternalsMessageHandlerClient::RegisterMessages() { 59 void ChromeNTPTilesInternalsMessageHandlerClient::RegisterMessages() {
62 handler_.RegisterMessages(this); 60 handler_.RegisterMessages(this);
63 } 61 }
64 62
65 bool ChromeNTPTilesInternalsMessageHandlerClient::DoesSourceExist( 63 base::SequencedWorkerPool*
66 ntp_tiles::NTPTileSource source) { 64 ChromeNTPTilesInternalsMessageHandlerClient::GetBlockingPool() {
67 switch (source) { 65 return content::BrowserThread::GetBlockingPool();
68 case ntp_tiles::NTPTileSource::TOP_SITES:
69 case ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE:
70 case ntp_tiles::NTPTileSource::WHITELIST:
71 return true;
72 case ntp_tiles::NTPTileSource::POPULAR:
73 #if defined(OS_ANDROID)
74 return true;
75 #else
76 return false;
77 #endif
78 }
79 NOTREACHED();
80 return false;
81 } 66 }
82 67
83 std::unique_ptr<ntp_tiles::MostVisitedSites> 68 std::unique_ptr<ntp_tiles::MostVisitedSites>
84 ChromeNTPTilesInternalsMessageHandlerClient::MakeMostVisitedSites() { 69 ChromeNTPTilesInternalsMessageHandlerClient::MakeMostVisitedSites() {
85 return ChromeMostVisitedSitesFactory::NewForProfile( 70 return ChromeMostVisitedSitesFactory::NewForProfile(
86 Profile::FromWebUI(web_ui())); 71 Profile::FromWebUI(web_ui()));
87 } 72 }
88 73
89 std::unique_ptr<ntp_tiles::PopularSites>
90 ChromeNTPTilesInternalsMessageHandlerClient::MakePopularSites() {
91 #if defined(OS_ANDROID)
92 return ChromePopularSitesFactory::NewForProfile(Profile::FromWebUI(web_ui()));
93 #else
94 return nullptr;
95 #endif
96 }
97
98 PrefService* ChromeNTPTilesInternalsMessageHandlerClient::GetPrefs() { 74 PrefService* ChromeNTPTilesInternalsMessageHandlerClient::GetPrefs() {
99 return Profile::FromWebUI(web_ui())->GetPrefs(); 75 return Profile::FromWebUI(web_ui())->GetPrefs();
100 } 76 }
101 77
102 void ChromeNTPTilesInternalsMessageHandlerClient::RegisterMessageCallback( 78 void ChromeNTPTilesInternalsMessageHandlerClient::RegisterMessageCallback(
103 const std::string& message, 79 const std::string& message,
104 const base::Callback<void(const base::ListValue*)>& callback) { 80 const base::Callback<void(const base::ListValue*)>& callback) {
105 web_ui()->RegisterMessageCallback(message, callback); 81 web_ui()->RegisterMessageCallback(message, callback);
106 } 82 }
107 83
(...skipping 17 matching lines...) Expand all
125 } // namespace 101 } // namespace
126 102
127 NTPTilesInternalsUI::NTPTilesInternalsUI(content::WebUI* web_ui) 103 NTPTilesInternalsUI::NTPTilesInternalsUI(content::WebUI* web_ui)
128 : WebUIController(web_ui) { 104 : WebUIController(web_ui) {
129 content::WebUIDataSource::Add(Profile::FromWebUI(web_ui), 105 content::WebUIDataSource::Add(Profile::FromWebUI(web_ui),
130 CreateNTPTilesInternalsHTMLSource()); 106 CreateNTPTilesInternalsHTMLSource());
131 web_ui->AddMessageHandler(new ChromeNTPTilesInternalsMessageHandlerClient); 107 web_ui->AddMessageHandler(new ChromeNTPTilesInternalsMessageHandlerClient);
132 } 108 }
133 109
134 NTPTilesInternalsUI::~NTPTilesInternalsUI() {} 110 NTPTilesInternalsUI::~NTPTilesInternalsUI() {}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698