WebBlendModeNormal should map to SkBlendMode::kSrcOver

WebBlendModeNormal should map to SkBlendMode::kSrcOver

Although the value gMapBlendOpsToXfermodeModes[WebBlendModeNormal] is never
used by WebCoreCompositeToSkiaComposite() with an early branch. As a matter
of principle we should not allow such footgun. This CL doesn't change behavior.

Committed: https://crrev.com/a006c619fc954ae4b6551355f2eb521a0f29c7b4
Cr-Commit-Position: refs/heads/master@{#438678}

[trchen, 2016-12-14 02:37:14]

trchen@chromium.org changed reviewers:
+ pdr@chromium.org

[trchen, 2016-12-14 02:37:14]

This is no-op CL. Witnessing the bogus value gave me a cold sweat.

[trchen, 2016-12-14 02:37:19]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 02:37:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 04:05:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 04:05:53]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-12-14 23:29:20]

On 2016/12/14 at 02:37:14, trchen wrote:
> This is no-op CL. Witnessing the bogus value gave me a cold sweat.

LGTM

WDYT of updating the comment to poitn to BlendModeToSkia?

[trchen, 2016-12-14 23:37:25]

The CQ bit was checked by trchen@chromium.org

[commit-bot: I haz the power, 2016-12-14 23:38:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 23:48:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481758645998370, "parent_rev":
"b1d52ca3feb1b67a4c2ccc8dfbc60a97d6f0f637", "commit_rev":
"32f919a0f40a8d7ee8c1254e658e1cf7ed1dfc64"}

[commit-bot: I haz the power, 2016-12-14 23:48:48]

Description was changed from

==========
WebBlendModeNormal should map to SkBlendMode::kSrcOver

Although the value gMapBlendOpsToXfermodeModes[WebBlendModeNormal] is never
used by WebCoreCompositeToSkiaComposite() with an early branch. As a matter
of principle we should not allow such footgun. This CL doesn't change behavior.
==========

to

==========
WebBlendModeNormal should map to SkBlendMode::kSrcOver

Although the value gMapBlendOpsToXfermodeModes[WebBlendModeNormal] is never
used by WebCoreCompositeToSkiaComposite() with an early branch. As a matter
of principle we should not allow such footgun. This CL doesn't change behavior.

Review-Url: https://codereview.chromium.org/2571953003
==========

[commit-bot: I haz the power, 2016-12-14 23:48:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 23:52:34]

Description was changed from

==========
WebBlendModeNormal should map to SkBlendMode::kSrcOver

Although the value gMapBlendOpsToXfermodeModes[WebBlendModeNormal] is never
used by WebCoreCompositeToSkiaComposite() with an early branch. As a matter
of principle we should not allow such footgun. This CL doesn't change behavior.

Review-Url: https://codereview.chromium.org/2571953003
==========

to

==========
WebBlendModeNormal should map to SkBlendMode::kSrcOver

Although the value gMapBlendOpsToXfermodeModes[WebBlendModeNormal] is never
used by WebCoreCompositeToSkiaComposite() with an early branch. As a matter
of principle we should not allow such footgun. This CL doesn't change behavior.

Committed: https://crrev.com/a006c619fc954ae4b6551355f2eb521a0f29c7b4
Cr-Commit-Position: refs/heads/master@{#438678}
==========

[commit-bot: I haz the power, 2016-12-14 23:52:35]

Patchset 1 (id:??) landed as
https://crrev.com/a006c619fc954ae4b6551355f2eb521a0f29c7b4
Cr-Commit-Position: refs/heads/master@{#438678}