Set overflow: auto in StyleResolver::styleForDocument.

[Reland] Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

This relands r438533 which was reverted in r438537.

BUG=672335
Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Committed: https://crrev.com/b8ad7cfdc0f044af7f16598b5cbc4170a7783e61
Cr-Original-Commit-Position: refs/heads/master@{#438533}
Cr-Commit-Position: refs/heads/master@{#438616}

[skobes, 2016-12-14 00:38:27]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 00:39:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2016-12-14 01:07:46]

Description was changed from

==========
Set overflow: auto in StyleResolver::styleForDocument.

BUG=672335
==========

to

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to LayoutObject::setStyle in Document::updateStyle would
mark the LayoutView as overflow: visible.  In root layer scrolling mode, this
causes PaintLayerScrollableArea to remove the scrollbars.

BUG=672335
==========

[skobes, 2016-12-14 01:29:01]

Description was changed from

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to LayoutObject::setStyle in Document::updateStyle would
mark the LayoutView as overflow: visible.  In root layer scrolling mode, this
causes PaintLayerScrollableArea to remove the scrollbars.

BUG=672335
==========

to

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles and is never "visible" regardless of RLS.

BUG=672335
==========

[skobes, 2016-12-14 01:34:01]

Description was changed from

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles and is never "visible" regardless of RLS.

BUG=672335
==========

to

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

BUG=672335
==========

[commit-bot: I haz the power, 2016-12-14 02:45:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 02:45:23]

Dry run: This issue passed the CQ dry run.

[skobes, 2016-12-14 04:33:00]

skobes@chromium.org changed reviewers:
+ bokan@chromium.org, szager@chromium.org

[bokan, 2016-12-14 13:40:44]

lgtm

For my own benefit, why do the scrollbars flicker? If it removes and adds
scrollbars within Document::updateStyle, we shouldn't have generated a frame
without scrollbars, right?

[skobes, 2016-12-14 16:47:53]

On 2016/12/14 13:40:44, bokan wrote:
> lgtm
> 
> For my own benefit, why do the scrollbars flicker? If it removes and adds
> scrollbars within Document::updateStyle, we shouldn't have generated a frame
> without scrollbars, right?

PLSA is eager to remove scrollbars on auto -> visible, but for visible -> auto
it wants to wait until updateAfterLayout to add them.  That layout won't
necessarily happen.  (The document is exempt from the layout-invalidation code
in LayoutObject::setStyle because its m_parent is null.  That's arguably a bug,
but fixing it requires refactoring Document::updateStyle to only call setStyle
once, which is a bigger change.)

[bokan, 2016-12-14 16:49:45]

On 2016/12/14 16:47:53, skobes wrote:
> On 2016/12/14 13:40:44, bokan wrote:
> > lgtm
> > 
> > For my own benefit, why do the scrollbars flicker? If it removes and adds
> > scrollbars within Document::updateStyle, we shouldn't have generated a frame
> > without scrollbars, right?
> 
> PLSA is eager to remove scrollbars on auto -> visible, but for visible -> auto
> it wants to wait until updateAfterLayout to add them.  That layout won't
> necessarily happen.  (The document is exempt from the layout-invalidation code
> in LayoutObject::setStyle because its m_parent is null.  That's arguably a
bug,
> but fixing it requires refactoring Document::updateStyle to only call setStyle
> once, which is a bigger change.)

Ah, ok, thanks for the explanation.

[skobes, 2016-12-14 16:52:16]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:52:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 16:57:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481734336361320, "parent_rev":
"8a8b48decebc3dc16433edd8e07010aa866535f0", "commit_rev":
"f0ade73900d081ce4ce150825a9858d8d971a008"}

[commit-bot: I haz the power, 2016-12-14 16:57:54]

Description was changed from

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

BUG=672335
==========

to

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

BUG=672335

Review-Url: https://codereview.chromium.org/2571893003
==========

[commit-bot: I haz the power, 2016-12-14 16:57:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 17:00:24]

Description was changed from

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

BUG=672335

Review-Url: https://codereview.chromium.org/2571893003
==========

to

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Cr-Commit-Position: refs/heads/master@{#438533}
==========

[commit-bot: I haz the power, 2016-12-14 17:00:25]

Patchset 1 (id:??) landed as
https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Cr-Commit-Position: refs/heads/master@{#438533}

[paulmeyer, 2016-12-14 17:12:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2570293003/ by paulmeyer@chromium.org.

The reason for reverting is: This breaks compiles on Android Cast bot:
https://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%....

[findit-for-me, 2016-12-14 17:14:32]

FYI: Findit identified this CL at revision 438533 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[Theresa, 2016-12-14 17:16:59]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2562333005/ by twellington@chromium.org.

The reason for reverting is: This broke compilation and automatically closed the
tree; reverting to get the tree open. Example compilation failure:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Buil...

../../third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp: In static
member function 'static WTF::PassRefPtr<blink::ComputedStyle>
blink::StyleResolver::styleForDocument(blink::Document&)':
../../third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:628:31:
error: 'OverflowAuto' was not declared in this scope
   documentStyle->setOverflowX(OverflowAuto);.

[skobes, 2016-12-14 18:48:57]

Description was changed from

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Cr-Commit-Position: refs/heads/master@{#438533}
==========

to

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Cr-Commit-Position: refs/heads/master@{#438533}
==========

[skobes, 2016-12-14 18:52:49]

Description was changed from

==========
Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Cr-Commit-Position: refs/heads/master@{#438533}
==========

to

==========
[Reland] Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

This relands r438533 which was reverted in r438537.

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Cr-Commit-Position: refs/heads/master@{#438533}
==========

[skobes, 2016-12-14 18:57:35]

Patchset #2 (id:20001) has been deleted

[skobes, 2016-12-14 19:00:21]

Patchset #1 collided with http://crrev.com/2569013006, which renamed the
EOverflow values.  Relanding.

[skobes, 2016-12-14 19:00:26]

The CQ bit was checked by skobes@chromium.org

[skobes, 2016-12-14 19:00:27]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/2571893003/#ps60001
(title: "resolve merge conflict with r438458")

[commit-bot: I haz the power, 2016-12-14 19:01:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[szager1, 2016-12-14 19:30:10]

On 2016/12/14 16:47:53, skobes wrote:
> On 2016/12/14 13:40:44, bokan wrote:
> > lgtm
> > 
> > For my own benefit, why do the scrollbars flicker? If it removes and adds
> > scrollbars within Document::updateStyle, we shouldn't have generated a frame
> > without scrollbars, right?
> 
> PLSA is eager to remove scrollbars on auto -> visible, but for visible -> auto
> it wants to wait until updateAfterLayout to add them.  That layout won't
> necessarily happen.  (The document is exempt from the layout-invalidation code
> in LayoutObject::setStyle because its m_parent is null.  That's arguably a
bug,
> but fixing it requires refactoring Document::updateStyle to only call setStyle
> once, which is a bigger change.)

That's the question that stopped me cold when reviewing this.  File a bug?

[skobes, 2016-12-14 19:58:04]

On 2016/12/14 19:30:10, szager1 wrote:
> That's the question that stopped me cold when reviewing this.  File a bug?

Filed http://crbug.com/674246.

[szager1, 2016-12-14 20:01:36]

Thanks, lgtm

[commit-bot: I haz the power, 2016-12-14 20:48:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481742026930910,
"parent_rev": "f4bb20cd7d67faba04d33c6579b78ac4397d4145", "commit_rev":
"eb15b1e457ac4eff5527c550e121deda893e6cb5"}

[commit-bot: I haz the power, 2016-12-14 20:49:07]

Description was changed from

==========
[Reland] Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

This relands r438533 which was reverted in r438537.

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Cr-Commit-Position: refs/heads/master@{#438533}
==========

to

==========
[Reland] Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

This relands r438533 which was reverted in r438537.

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Cr-Commit-Position: refs/heads/master@{#438533}
Review-Url: https://codereview.chromium.org/2571893003
==========

[commit-bot: I haz the power, 2016-12-14 20:49:08]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-12-14 20:53:47]

Description was changed from

==========
[Reland] Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

This relands r438533 which was reverted in r438537.

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Cr-Commit-Position: refs/heads/master@{#438533}
Review-Url: https://codereview.chromium.org/2571893003
==========

to

==========
[Reland] Set overflow: auto in StyleResolver::styleForDocument.

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

This relands r438533 which was reverted in r438537.

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Committed: https://crrev.com/b8ad7cfdc0f044af7f16598b5cbc4170a7783e61
Cr-Original-Commit-Position: refs/heads/master@{#438533}
Cr-Commit-Position: refs/heads/master@{#438616}
==========

[commit-bot: I haz the power, 2016-12-14 20:53:48]

Patchset 3 (id:??) landed as
https://crrev.com/b8ad7cfdc0f044af7f16598b5cbc4170a7783e61
Cr-Commit-Position: refs/heads/master@{#438616}