Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2571873002: histograms: register new CrOS watchdog event (Closed)

Created:
4 years ago by vapier
Modified:
4 years ago
Reviewers:
rkaplow
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

histograms: register new CrOS watchdog event This is used whenever the watchdog service (daisydog) fails to start up correctly. We don't expect this to happen on real devices, so we want to get a handle if it actually does (and how often). BUG=673501 Committed: https://crrev.com/74931624d8d247d97e7b32afe0e666c51c3f598b Cr-Commit-Position: refs/heads/master@{#438643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
vapier
4 years ago (2016-12-13 19:28:19 UTC) #2
rkaplow
lgtm
4 years ago (2016-12-14 20:41:50 UTC) #3
vapier
here's the CL on the CrOS side using the new enum: https://chromium-review.googlesource.com/420363
4 years ago (2016-12-14 20:42:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571873002/1
4 years ago (2016-12-14 20:43:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 21:56:20 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-14 21:58:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74931624d8d247d97e7b32afe0e666c51c3f598b
Cr-Commit-Position: refs/heads/master@{#438643}

Powered by Google App Engine
This is Rietveld 408576698