Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2571863003: Add explicit conversions methods for WebString <-> string16 (Closed)

Created:
4 years ago by kinuko
Modified:
4 years ago
Reviewers:
haraken, esprehn, dcheng
CC:
chromium-reviews, blink-reviews, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add explicit conversions methods for WebString <-> string16 Initial patch to remove implicit conversions. This CL adds following utf16 conversion methods and use them in blink_platform_impl.cc to show how it'd look like. * static WebString WebString::fromUTF16(const string16&); * static WebString WebString::fromUTF16(const NullableString16&); * string16 WebString::utf16(); * static NullableString16 WebString::toNullableString16(); BUG=667131 Committed: https://crrev.com/d3054687cf8c2b90c25914065acaee0eb0a5ca28 Cr-Commit-Position: refs/heads/master@{#438801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -14 lines) Patch
M content/child/blink_platform_impl.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebString.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebString.h View 4 chunks +42 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
kinuko
Strip down the CL so that it only contains WebString changes (and one callsite to ...
4 years ago (2016-12-15 06:38:56 UTC) #7
dcheng
lgtm!
4 years ago (2016-12-15 06:52:35 UTC) #8
haraken
LGTM
4 years ago (2016-12-15 07:28:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571863003/1
4 years ago (2016-12-15 08:16:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 10:49:10 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-15 10:51:12 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3054687cf8c2b90c25914065acaee0eb0a5ca28
Cr-Commit-Position: refs/heads/master@{#438801}

Powered by Google App Engine
This is Rietveld 408576698