Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 2571793002: [turbofan] fixed escape analysis crash because of incomplete replacements (Closed)

Created:
4 years ago by Tobias Tebbi
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Jarin
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] fixed escape analysis crash because of incomplete replacements R=epertoso@chromium.org,mstarzinger@chromium.org BUG=671324 Committed: https://crrev.com/c22c70b6053eb305d537831fc309296a1c888988 Cr-Commit-Position: refs/heads/master@{#41679}

Patch Set 1 #

Patch Set 2 : missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -4 lines) Patch
M src/compiler/escape-analysis.h View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/escape-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/escape-analysis-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 3 chunks +10 lines, -2 lines 0 comments Download
A test/mjsunit/compiler/escape-analysis-replacement.js View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Tobias Tebbi
However, this does not explain all the crashes we observed.
4 years ago (2016-12-13 13:40:41 UTC) #1
Tobias Tebbi
On 2016/12/13 13:40:41, Tobias Tebbi wrote: > However, this does not explain all the crashes ...
4 years ago (2016-12-13 13:46:00 UTC) #3
epertoso
lgtm
4 years ago (2016-12-13 13:58:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571793002/20001
4 years ago (2016-12-13 14:02:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
4 years ago (2016-12-13 16:03:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571793002/20001
4 years ago (2016-12-13 16:16:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 16:24:16 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 16:25:37 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c22c70b6053eb305d537831fc309296a1c888988
Cr-Commit-Position: refs/heads/master@{#41679}

Powered by Google App Engine
This is Rietveld 408576698