Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2571783002:
Disable flaky tests in ContextualSearchManagerTest.java suite (Closed)
DescriptionDisable flaky tests in ContextualSearchManagerTest.java suite
BUG=673681
TBR=donnd@chromium.org,twellington@chromium.org
Committed: https://crrev.com/00ec53a017409e5f1b13cc6b5dbaf9ac196f8178
Cr-Commit-Position: refs/heads/master@{#438180}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Address review comment #Messages
Total messages: 19 (11 generated)
Description was changed from ========== Disable flaky tests in ContextualSearchManagerTest.java suite BUG=673681 ========== to ========== Disable flaky tests in ContextualSearchManagerTest.java suite BUG=673681 TBR=donnd@chromium.org,twellington@chromium.org ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java:
While running git apply --index -p1;
error: patch failed:
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java:2014
error:
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java:
patch does not apply
Patch:
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
Index:
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
diff --git
a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
index
f4dfdbe4169b85215ebc5019ba437d160df3527b..336a03e86cb0a9bfc7de1f4e20d9fdbc6da4895f
100644
---
a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
+++
b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
@@ -2014,9 +2014,10 @@ public class ContextualSearchManagerTest extends
ChromeActivityTestCaseBase<Chro
* modified after the user has taken an action to explicitly dismiss the
panel. Also tests
* that the panel reappears when a new selection is made.
*/
- @SmallTest
- @Feature({"ContextualSearch"})
- @RetryOnFailure
+ // @SmallTest
+ // @Feature({"ContextualSearch"})
+ // @RetryOnFailure
+ @DisabledTest(message = "crbug.com/673681")
public void testPreventHandlingCurrentSelectionModification()
throws InterruptedException, TimeoutException {
longPressNode("intelligence");
@@ -2746,8 +2747,9 @@ public class ContextualSearchManagerTest extends
ChromeActivityTestCaseBase<Chro
* Tests that the quick action caption is set correctly when one is
available. Also tests that
* the caption gets changed when the panel is expanded and reset when the
panel is closed.
*/
- @SmallTest
- @Feature({"ContextualSearch"})
+ // @SmallTest
+ // @Feature({"ContextualSearch"})
+ @DisabledTest(message = "crbug.com/673681")
public void testQuickActionCaptionAndImage() throws InterruptedException,
TimeoutException {
// Simulate a tap to show the Bar, then set the quick action data.
simulateTapSearch("search");
twellington@chromium.org changed reviewers: + twellington@chromium.org
https://codereview.chromium.org/2571783002/diff/1/chrome/android/javatests/sr... File chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java (right): https://codereview.chromium.org/2571783002/diff/1/chrome/android/javatests/sr... chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java:2020: @DisabledTest(message = "crbug.com/673681") Remove this line - another CL already added the annotation. https://codereview.chromium.org/2571783002/diff/1/chrome/android/javatests/sr... chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java:2752: @DisabledTest(message = "crbug.com/673681") Add @RetryOnFailure instead of @Disabled and uncomment the two lines above this. The flakiness dashboard shows that this test flakes very infrequently and a culprit CL could not be identified, so @RetryOnFailure seems like the better solution so that this code path still gets test coverage.
https://codereview.chromium.org/2571783002/diff/1/chrome/android/javatests/sr... File chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java (right): https://codereview.chromium.org/2571783002/diff/1/chrome/android/javatests/sr... chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java:2020: @DisabledTest(message = "crbug.com/673681") On 2016/12/13 15:02:42, Theresa Wellington wrote: > Remove this line - another CL already added the annotation. Done. https://codereview.chromium.org/2571783002/diff/1/chrome/android/javatests/sr... chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java:2752: @DisabledTest(message = "crbug.com/673681") On 2016/12/13 15:02:42, Theresa Wellington wrote: > Add @RetryOnFailure instead of @Disabled and uncomment the two lines above this. > The flakiness dashboard shows that this test flakes very infrequently and a > culprit CL could not be identified, so @RetryOnFailure seems like the better > solution so that this code path still gets test coverage. Done.
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM, thanks!
The CQ bit was unchecked by twellington@chromium.org
The CQ bit was checked by twellington@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481643231010930,
"parent_rev": "2ef515de44342bc650fd30e565667634a2cb8420", "commit_rev":
"efbf2927b6dbf7302b05bc21bcae6b33c92a1e54"}
Message was sent while issue was closed.
Description was changed from ========== Disable flaky tests in ContextualSearchManagerTest.java suite BUG=673681 TBR=donnd@chromium.org,twellington@chromium.org ========== to ========== Disable flaky tests in ContextualSearchManagerTest.java suite BUG=673681 TBR=donnd@chromium.org,twellington@chromium.org Review-Url: https://codereview.chromium.org/2571783002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable flaky tests in ContextualSearchManagerTest.java suite BUG=673681 TBR=donnd@chromium.org,twellington@chromium.org Review-Url: https://codereview.chromium.org/2571783002 ========== to ========== Disable flaky tests in ContextualSearchManagerTest.java suite BUG=673681 TBR=donnd@chromium.org,twellington@chromium.org Committed: https://crrev.com/00ec53a017409e5f1b13cc6b5dbaf9ac196f8178 Cr-Commit-Position: refs/heads/master@{#438180} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/00ec53a017409e5f1b13cc6b5dbaf9ac196f8178 Cr-Commit-Position: refs/heads/master@{#438180} |
