Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2571713006: Fix some thread safety violations in device::GvrDelegate implementation. (Closed)

Created:
4 years ago by mthiesse
Modified:
4 years ago
Reviewers:
klausw, bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some thread safety violations in device::GvrDelegate implementation. Also fixes some missed nits in https://codereview.chromium.org/2562733002/ BUG=671302 Committed: https://crrev.com/25adbad06941a56f6ffe5a45ab8b50e9194ea487 Cr-Commit-Position: refs/heads/master@{#438587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -77 lines) Patch
M chrome/browser/android/vr_shell/vr_compositor.h View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_compositor.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 6 chunks +26 lines, -32 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.h View 3 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 5 chunks +6 lines, -33 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mthiesse
PTAL
4 years ago (2016-12-13 23:42:33 UTC) #2
bshe
On 2016/12/13 23:42:33, mthiesse wrote: > PTAL lgtm
4 years ago (2016-12-14 16:29:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571713006/1
4 years ago (2016-12-14 16:38:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 19:27:14 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-14 19:31:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25adbad06941a56f6ffe5a45ab8b50e9194ea487
Cr-Commit-Position: refs/heads/master@{#438587}

Powered by Google App Engine
This is Rietveld 408576698