DevTools: untruncate links on console export

DevTools: untruncate links on console export

BUG=505177
Review-Url: https://codereview.chromium.org/2571713005
Cr-Commit-Position: refs/heads/master@{#443411}
Committed: https://chromium.googlesource.com/chromium/src/+/9f3f2c8a92072d2e0a7194f6ebd3547c3609cb09

[luoe, 2016-12-13 23:42:54]

Description was changed from

==========
DevTools: untruncate links on console export

BUG=
==========

to

==========
DevTools: untruncate links on console export

BUG=505177
==========

[luoe, 2016-12-13 23:44:43]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-12-13 23:44:44]

ptal

[dgozman, 2016-12-14 17:25:07]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-12-14 17:25:07]

https://codereview.chromium.org/2571713005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2571713005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:397:
link.textContent =
text.trimMiddle(Components.Linkifier.MaxLengthForDisplayedURLs);
Why do we trim to the same length? Previously we didn't.

[luoe, 2016-12-17 01:18:20]

In the latest patch, I renamed console-message-url to console-message-anchor. 
The structure changes from:

- console-message-url.devtools-link
  - TextNode(url)
  - TextNode(' ')

to

- console-message-anchor
  - span.devtools-link
    - TextNode(url)
  - TextNode(' ')

which allows the transformer function in ConsoleViewMessage to simply check if
the parent is a devtools-link.

With ConsoleViewMessage.toExportString, we can now test export strings.

https://codereview.chromium.org/2571713005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2571713005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:397:
link.textContent =
text.trimMiddle(Components.Linkifier.MaxLengthForDisplayedURLs);
Right, I did not intend to change this.  Let me have a maxLength parameter

[dgozman, 2016-12-19 18:38:01]

https://codereview.chromium.org/2571713005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2571713005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:362:
linkText, className || '', Components.Linkifier.MaxLengthForDisplayedURLs,
title, url, preventClick);
150

https://codereview.chromium.org/2571713005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
(right):

https://codereview.chromium.org/2571713005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js:587:
Node.prototype.deepTextContent = function(transform) {
Instead of adding transform here, let's copy this directly to console export
code.

[luoe, 2016-12-19 19:44:39]

https://codereview.chromium.org/2571713005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2571713005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:362:
linkText, className || '', Components.Linkifier.MaxLengthForDisplayedURLs,
title, url, preventClick);
This was 150 before, but since MaxLengthForDisplayedURL is already set to 150,
can we reuse the const?

https://codereview.chromium.org/2571713005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
(right):

https://codereview.chromium.org/2571713005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js:587:
Node.prototype.deepTextContent = function(transform) {
On 2016/12/19 18:38:01, dgozman wrote:
> Instead of adding transform here, let's copy this directly to console export
> code.

Done.

[luoe, 2016-12-19 19:45:38]

Also in the last patch, I moved the const into UIUtils so createExternalLink
could use the same value instead of another hard coded 150.

[luoe, 2017-01-05 02:18:59]

On 2016/12/19 19:45:38, luoe wrote:
> Also in the last patch, I moved the const into UIUtils so createExternalLink
> could use the same value instead of another hard coded 150.

Gentle ping

[dgozman, 2017-01-10 01:03:30]

lgtm

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/console/console-export.html
(right):

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-export.html:11:
console.error('foo');
Let's have a single message with multiple urls as well (both short and long
ones).

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:1101:
var messageContent = this.contentElement()
Let's reformat somehow...

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:1103:
.map(node => {
var nodes = ...;
for (var index = 0; index < nodes.length; index++) {
  ...
}

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right):

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:2000: * The maximum
number of characters to display in a URL.
Let's remove the comment.

[luoe, 2017-01-10 22:21:45]

Thanks for the review!

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/console/console-export.html
(right):

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-export.html:11:
console.error('foo');
On 2017/01/10 01:03:30, dgozman wrote:
> Let's have a single message with multiple urls as well (both short and long
> ones).

Done.

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:1101:
var messageContent = this.contentElement()
On 2017/01/10 01:03:30, dgozman wrote:
> Let's reformat somehow...

Done.

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:1103:
.map(node => {
On 2017/01/10 01:03:30, dgozman wrote:
> var nodes = ...;
> for (var index = 0; index < nodes.length; index++) {
>   ...
> }

Done.

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right):

https://codereview.chromium.org/2571713005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:2000: * The maximum
number of characters to display in a URL.
On 2017/01/10 01:03:30, dgozman wrote:
> Let's remove the comment.

Done.

[luoe, 2017-01-11 19:26:22]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 19:27:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:33:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[luoe, 2017-01-12 21:58:11]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 21:58:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:07:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 00:07:27]

Dry run: This issue passed the CQ dry run.

[luoe, 2017-01-13 00:07:58]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-01-13 00:07:58]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2571713005/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-13 00:09:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:30:37]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484266078386410,
"parent_rev": "5db4d106559db54bf67baf7dc6cce91b41dca812", "commit_rev":
"9f3f2c8a92072d2e0a7194f6ebd3547c3609cb09"}

[commit-bot: I haz the power, 2017-01-13 00:31:12]

Description was changed from

==========
DevTools: untruncate links on console export

BUG=505177
==========

to

==========
DevTools: untruncate links on console export

BUG=505177

Review-Url: https://codereview.chromium.org/2571713005
Cr-Commit-Position: refs/heads/master@{#443411}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f3f2c8a92072d2e0a7194f6ebd3...
==========

[commit-bot: I haz the power, 2017-01-13 00:31:15]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9f3f2c8a92072d2e0a7194f6ebd3...